Re: [PATCH v4 12/13] ARM: dts: sun4i: a10: add sata-port/sata-phy nodes

Maxime Ripard
2018-08-31T10:21:10Z

[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]

On Fri, Aug 31, 2018 at 09:53:50AM +0200, Corentin Labbe wrote:
> On Fri, Aug 31, 2018 at 09:37:24AM +0200, Maxime Ripard wrote:
> > On Thu, Aug 30, 2018 at 09:01:19PM +0200, Corentin Labbe wrote:
> > > This patch convert sun4i-a10 sata to the new binding which use a sata
> > > phy node.
> > >
> > > Signed-off-by: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > ---
> > > arch/arm/boot/dts/sun4i-a10.dtsi | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> > > index 3d62a8950720..52d5c2e79499 100644
> > > --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> > > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> > > @@ -556,7 +556,20 @@
> > > reg = <0x01c18000 0x1000>;
> > > interrupts = <56>;
> > > clocks = <&ccu CLK_AHB_SATA>, <&ccu CLK_SATA>;
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > status = "disabled";
> > > +
> > > + sata_port: sata-port@0 {
> > > + reg = <0>;
> > > + phys = <&sata_phy>;
> > > + };
> > > + };
> > > +
> > > + sata_phy: sata_phy@1c180c0 {
> > > + compatible = "allwinner,sun4i-a10-sata-phy";
> > > + reg = <0x01c180c0 0x200>;
> > > + #phy-cells = <0>;
> > > };
> >
> > This patch, together with the following one, breaks the DT ABI, this
> > isn't something we can do anymore.
>
> So what can I do ?

Well, you always have the option of not doing anything.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering