From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
axboe@kernel.dk, b.zolnierkie@samsung.com,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL_82371AB
Date: Tue, 12 Mar 2019 12:06:23 +0000 [thread overview]
Message-ID: <20190312120623.46ca7286@alans-desktop> (raw)
In-Reply-To: <20190312104102.GA28302@Red>
On Tue, 12 Mar 2019 11:41:02 +0100
LABBE Corentin <clabbe@baylibre.com> wrote:
> On Mon, Dec 10, 2018 at 05:52:35PM +0300, Sergei Shtylyov wrote:
> > Hello!
> >
> > On 12/10/2018 04:46 PM, Corentin Labbe wrote:
> >
> > > When playing with a virtual SPARC machine with qemu, I found that the
> > > IDE emulated device was not probing with the ata/pata_oldpiix driver.
> >
> > Correctly, it should probe with ata_piix,
> >
> > > But with the old ide/piix, it was probed.>
> > > This is due to this PCI devid was not migrated from the old ide/piix.
> >
> > It wasn't on purpose -- the IDE driver supports the original PIIX
> > incorrectly.
> >
>
> Hello
>
> What about removing this old driver totally if it dont work ?
If the virtual Sparc emulator is using it does that also mean actual
Sparc hardware has it. In which case presumably it needs fixing, or at
least moving to the generic driver assuming the firmware sets it up ?
Alan
next prev parent reply other threads:[~2019-03-12 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 13:46 [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL_82371AB Corentin Labbe
2018-12-10 14:52 ` Sergei Shtylyov
2019-03-12 10:41 ` LABBE Corentin
2019-03-12 10:44 ` Sergei Shtylyov
2019-03-12 12:06 ` Alan Cox [this message]
2019-03-12 13:38 ` LABBE Corentin
2019-03-22 17:36 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312120623.46ca7286@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=clabbe@baylibre.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).