From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
axboe@kernel.dk, b.zolnierkie@samsung.com,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL_82371AB
Date: Fri, 22 Mar 2019 17:36:43 +0000 [thread overview]
Message-ID: <20190322173643.75a81d1b@alans-desktop> (raw)
In-Reply-To: <20190312133808.GA9336@Red>
> > If the virtual Sparc emulator is using it does that also mean actual
> > Sparc hardware has it. In which case presumably it needs fixing, or at
> > least moving to the generic driver assuming the firmware sets it up ?
> >
>
> The qemu works perfectly with the new Linux driver.
For some configurations both drivers will work with even older chips. The
question is whether your chip has separate slave timings, if not then
while it'll work single device with ata_piix some combinations will fail.
Digging into the datasheet the part in question has slave timing (0x44) so
should indeed be ata_piix.
Alan
prev parent reply other threads:[~2019-03-22 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 13:46 [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL_82371AB Corentin Labbe
2018-12-10 14:52 ` Sergei Shtylyov
2019-03-12 10:41 ` LABBE Corentin
2019-03-12 10:44 ` Sergei Shtylyov
2019-03-12 12:06 ` Alan Cox
2019-03-12 13:38 ` LABBE Corentin
2019-03-22 17:36 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322173643.75a81d1b@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=clabbe@baylibre.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).