From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537BDC33C9E for ; Tue, 7 Jan 2020 19:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B03F2077B for ; Tue, 7 Jan 2020 19:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578425453; bh=RcixPhzFLFpfoeFpHnTwEM2jSreesLXT8nwQzlKShsI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KT28gRGBYmJPNcgHFw9XQ+qLxrQZzC9ZTdbikdagcFxfp+tMOrULi8S8q/vFyY+HI kbIeX/wUiMS+6zzijVUuO9wk0YAQVYJfGeUelrXV1rGDozvQppdm3piMV62eJBN6Xl J/xZ96v3T9k3l+wpmgVKfwA+XABwUkqwagpvPXiA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728757AbgAGTat (ORCPT ); Tue, 7 Jan 2020 14:30:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:41526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728307AbgAGTat (ORCPT ); Tue, 7 Jan 2020 14:30:49 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D66ED206DB; Tue, 7 Jan 2020 19:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578425448; bh=RcixPhzFLFpfoeFpHnTwEM2jSreesLXT8nwQzlKShsI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mspJgrcd3kka6cRo+m/U4Jk7qGCePRKsS2a86k+iP6adF9v7uQxR84KhP4c0z0NYh OcoENlWN8eKeW/waEEdBjCv613rFOeKnd8XONxxn2G5BBQ2Okfshb5GHklCCKkja0+ 7OtcjypDEs10nMLdEsmZ3sXif0Dld54tNdO8+eSg= Date: Tue, 7 Jan 2020 20:30:46 +0100 From: Greg Kroah-Hartman To: Florian Fainelli Cc: Naresh Kamboju , Sasha Levin , open list , bcm-kernel-feedback-list@broadcom.com, Jens Axboe , Rob Herring , Mark Rutland , Hans de Goede , Philipp Zabel , Tejun Heo , Jaedon Shin , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux- stable Subject: Re: [PATCH 0/8] ata: ahci_brcm: Fixes and new device support Message-ID: <20200107193046.GB2021584@kroah.com> References: <20191210185351.14825-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Tue, Jan 07, 2020 at 09:39:58AM -0800, Florian Fainelli wrote: > On 1/7/20 9:29 AM, Naresh Kamboju wrote: > > On Tue, 7 Jan 2020 at 22:17, Naresh Kamboju wrote: > >> > >> On Wed, 11 Dec 2019 at 00:25, Florian Fainelli wrote: > >>> > >>> Hi Jens, > >>> > >>> The first 4 patches are fixes and should ideally be queued up/picked up > >>> by stable. The last 4 patches add support for BCM7216 which is one of > >>> our latest devices supported by this driver. > >>> > >>> Patch #2 does a few things, but it was pretty badly broken before and it > >>> is hard not to fix all call sites (probe, suspend, resume) in one shot. > >>> > >>> Please let me know if you have any comments. > >>> > >>> Thanks! > >>> > >>> Florian Fainelli (8): > >>> ata: libahci_platform: Export again ahci_platform_able_phys() > >>> ata: ahci_brcm: Fix AHCI resources management > >> > >> Following error on stable-rc 4.14 and 4.9 branch for arm build. > > > > Following error on stable-rc 4.19, 4.14 and 4.9 branch for arm build. > > > >> > >> drivers/ata/ahci_brcm.c: In function 'brcm_ahci_probe': > >> drivers/ata/ahci_brcm.c:412:28: error: 'struct brcm_ahci_priv' has no > >> member named 'rcdev'; did you mean 'dev'? > >> if (!IS_ERR_OR_NULL(priv->rcdev)) > >> ^~~~~ > >> dev > >> CC fs/pnode.o > >> CC block/genhd.o > >> drivers/ata/ahci_brcm.c:413:3: error: implicit declaration of > >> function 'reset_control_assert'; did you mean 'ahci_reset_controller'? > >> [-Werror=implicit-function-declaration] > >> reset_control_assert(priv->rcdev); > >> ^~~~~~~~~~~~~~~~~~~~ > >> ahci_reset_controller > >> drivers/ata/ahci_brcm.c:413:30: error: 'struct brcm_ahci_priv' has no > >> member named 'rcdev'; did you mean 'dev'? > >> reset_control_assert(priv->rcdev); > >> ^~~~~ > >> dev > >> cc1: some warnings being treated as errors > >> > >> Full build log links, > >> https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.14/DISTRO=lkft,MACHINE=am57xx-evm,label=docker-lkft/702/consoleText > >> https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.9/DISTRO=lkft,MACHINE=am57xx-evm,label=docker-lkft/773/consoleText > > https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.19/DISTRO=lkft,MACHINE=am57xx-evm,label=docker-lkft/404/consoleText > > The reset controller support was added in > 2b2c47d9e1fe90311b725125d6252a859ee87a79 ("ata: ahci_brcm: Allow > optional reset controller to be used") which was include in v4.20 and > newer so that explains the build failure. > > You may want to cherry pick that change into the respective stable > branches and then back port the fixes if that is not too much trouble. > If that does not work or is impractical, please let me know and I can > provide directed backport changes for 4.9, 4.14 and 4.19. No need, I'll just queue up the other needed patch now, thanks. greg k-h