From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 973B4C2D0CE for ; Tue, 21 Jan 2020 12:07:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B1EE2073A for ; Tue, 21 Jan 2020 12:07:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="n50CjAdt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729431AbgAUMHp (ORCPT ); Tue, 21 Jan 2020 07:07:45 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:52038 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728655AbgAUMHo (ORCPT ); Tue, 21 Jan 2020 07:07:44 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00LC3A4R018648; Tue, 21 Jan 2020 12:07:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=tdcR9JxADXhA1TYD2QHiLpZepwhEWa+ITm01KGLpQp0=; b=n50CjAdtc0ioDh2yWLG4Uy9G6g9WSvNrq8QxiXlWM0qTjU/XUN1o8wE0O85mA/4cFnRD kmbju7EMiLpNYkEy74LhKDv+l+A7lzdVF2GZZiFsvdw5I9iBDLnlXZT4SbwwEpbRD0nf eTz9F1tCUBx9IQrnco+P4sLg/brAiIhYgTdqphAyoUUZUI1nojEn8zz/W+ga2dfnPh6P d2/FR4kjdrzrz7wLf2JLtSJxqbfN8ZG1Fo9nSEymL2OLOQjIWcmQsbZpOL8/tsRnzp7G CDx6jFQjgGwgDvS9oDI8kFY9PaD+b2cIw6WizwTkFwlK+74Qv/L0/NepjaJQn3AlDE0R FA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2xksyq4fsy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jan 2020 12:07:35 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00LC3tdw159797; Tue, 21 Jan 2020 12:07:34 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2xnsa8ggmf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jan 2020 12:07:34 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 00LC7WBX006911; Tue, 21 Jan 2020 12:07:32 GMT Received: from kadam (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 21 Jan 2020 04:07:31 -0800 Date: Tue, 21 Jan 2020 15:07:25 +0300 From: Dan Carpenter To: Bartlomiej Zolnierkiewicz Cc: David Miller , linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: Re: [PATCH 1/2] cmd64x: potential buffer overflow in cmd64x_program_timings() Message-ID: <20200121120724.GC1847@kadam> References: <20200107130441.y3owvcnxdljailt5@kili.mountain> <20200120.144042.1810086369376110530.davem@davemloft.net> <20200121114835.GB1847@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200121114835.GB1847@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9506 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001210103 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9506 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001210103 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Tue, Jan 21, 2020 at 02:48:35PM +0300, Dan Carpenter wrote: > On Tue, Jan 21, 2020 at 12:15:54PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On 1/20/20 2:40 PM, David Miller wrote: > > > From: Dan Carpenter > > > Date: Tue, 7 Jan 2020 16:04:41 +0300 > > > > > >> The "drive->dn" value is a u8 and it is controlled by root only, but > > >> it could be out of bounds here so let's check. > > > > drive->dn should not be root controllable, please point me where it > > happens as this may need fixing instead of cmd64x driver. > > > > [ IDE core makes sure that drive->dn is never > 3 and a lot of code > > assumes it. ] > > > > It's a marked as a setable field in ide-proc.c > > drivers/ide/ide-proc.c > 206 ide_devset_rw(current_speed, xfer_rate); > 207 ide_devset_rw_field(init_speed, init_speed); > 208 ide_devset_rw_flag(nice1, IDE_DFLAG_NICE1); > 209 ide_devset_rw_field(number, dn); > ^^^^^^^^^^ > Sets ->dn > > 210 > 211 static const struct ide_proc_devset ide_generic_settings[] = { > 212 IDE_PROC_DEVSET(current_speed, 0, 70), > 213 IDE_PROC_DEVSET(init_speed, 0, 70), > 214 IDE_PROC_DEVSET(io_32bit, 0, 1 + (SUPPORT_VLB_SYNC << 1)), > 215 IDE_PROC_DEVSET(keepsettings, 0, 1), > 216 IDE_PROC_DEVSET(nice1, 0, 1), > 217 IDE_PROC_DEVSET(number, 0, 3), > 218 IDE_PROC_DEVSET(pio_mode, 0, 255), > 219 IDE_PROC_DEVSET(unmaskirq, 0, 1), > 220 IDE_PROC_DEVSET(using_dma, 0, 1), > 221 { NULL }, > 222 }; > > drivers/ide/ide-devsets.c > 159 int ide_devset_execute(ide_drive_t *drive, const struct ide_devset *setting, > 160 int arg) > 161 { > 162 struct request_queue *q = drive->queue; > 163 struct request *rq; > 164 int ret = 0; > 165 > 166 if (!(setting->flags & DS_SYNC)) > 167 return setting->set(drive, arg); > ^^^^^^^^^^^^^^^^^^^^^^^^ > Called from here according to Smatch. > Actually this is where I went wrong. The function is never called from here. Sorry for the noise. These patches are not required. regards, dan carpenter