From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ide: make drive->dn read only
Date: Tue, 21 Jan 2020 17:17:42 +0300 [thread overview]
Message-ID: <20200121141742.GB1870@kadam> (raw)
In-Reply-To: <beada2e3-29bd-2165-b6d7-d28a8c83060e@samsung.com>
On Tue, Jan 21, 2020 at 03:13:29PM +0100, Bartlomiej Zolnierkiewicz wrote:
>
> On 1/21/20 2:06 PM, Dan Carpenter wrote:
> > The IDE core always sets ->dn correctly so changing it is never
> > required.
> >
> > Setting it to a different value than assigned by IDE core is very likely
> > to result in data corruption (due to wrong transfer timings being set on
> > the controller etc.)
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks, it looks fine (though patch summary can be improved further i.e.:
> "[PATCH] ide-proc: make "number" setting read-only").
>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> I've also verified it (using ARAnyM emulator):
>
> Tested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
Thanks!
regards,
dan carpenter
next prev parent reply other threads:[~2020-01-21 14:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 13:04 [PATCH 1/2] cmd64x: potential buffer overflow in cmd64x_program_timings() Dan Carpenter
2020-01-07 13:06 ` [PATCH 2/2] ide: serverworks: potential overflow in svwks_set_pio_mode() Dan Carpenter
2020-01-20 13:40 ` David Miller
2020-01-21 11:18 ` Bartlomiej Zolnierkiewicz
2020-01-20 13:40 ` [PATCH 1/2] cmd64x: potential buffer overflow in cmd64x_program_timings() David Miller
2020-01-21 11:15 ` Bartlomiej Zolnierkiewicz
2020-01-21 11:48 ` Dan Carpenter
2020-01-21 11:55 ` Dan Carpenter
2020-01-21 12:07 ` Dan Carpenter
2020-01-21 12:21 ` Bartlomiej Zolnierkiewicz
2020-01-21 12:38 ` Bartlomiej Zolnierkiewicz
2020-01-21 13:06 ` [PATCH] ide: make drive->dn read only Dan Carpenter
2020-01-21 14:13 ` Bartlomiej Zolnierkiewicz
2020-01-21 14:17 ` Dan Carpenter [this message]
2020-01-30 10:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121141742.GB1870@kadam \
--to=dan.carpenter@oracle.com \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).