Re: [PATCH 21/46] sata_fsl: drop DPRINTK() calls in reset

Bartlomiej Zolnierkiewicz
2020-02-10T13:49:43Z

On 2/4/20 5:55 PM, Hannes Reinecke wrote:
> Reset is now logged with tracepoints, so the DPRINTK() calls can
> be dropped, and some calls can be dropped as they don't provide
> additional value.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/ata/sata_fsl.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> index 0864c4fafa39..5d48e1d223fa 100644
> --- a/drivers/ata/sata_fsl.c
> +++ b/drivers/ata/sata_fsl.c
> @@ -825,8 +825,6 @@ static int sata_fsl_hardreset(struct ata_link *link, unsigned int *class,
> int i = 0;
> unsigned long start_jiffies;
>
> - DPRINTK("in xx_hardreset\n");
> -
> try_offline_again:
> /*
> * Force host controller to go off-line, aborting current operations
> @@ -941,10 +939,7 @@ static int sata_fsl_softreset(struct ata_link *link, unsigned int *class,
> u8 *cfis;
> u32 Serror;
>
> - DPRINTK("in xx_softreset\n");
> -
> if (ata_link_offline(link)) {
> - DPRINTK("PHY reports no device\n");
> *class = ATA_DEV_NONE;
> return 0;
> }
> @@ -957,8 +952,6 @@ static int sata_fsl_softreset(struct ata_link *link, unsigned int *class,
> * reached here, we can send a command to the target device
> */
>
> - DPRINTK("Sending SRST/device reset\n");
> -
> ata_tf_init(link->device, &tf);
> cfis = (u8 *) &pp->cmdentry->cfis;
>
> @@ -1030,8 +1023,6 @@ static int sata_fsl_softreset(struct ata_link *link, unsigned int *class,
> */
> iowrite32(0x01, CC + hcr_base); /* We know it will be cmd#0 always */
>
> - DPRINTK("SATA FSL : Now checking device signature\n");
> -
> *class = ATA_DEV_NONE;
>
> /* Verify if SStatus indicates device presence */
> @@ -1045,7 +1036,6 @@ static int sata_fsl_softreset(struct ata_link *link, unsigned int *class,
>
> *class = sata_fsl_dev_classify(ap);
>
> - DPRINTK("class = %d\n", *class);
> VPRINTK("ccreg = 0x%x\n", ioread32(hcr_base + CC));
> VPRINTK("cereg = 0x%x\n", ioread32(hcr_base + CE));
> }
>