Re: [PATCH 45/46] libata: remove references to ATA_DEBUG

Bartlomiej Zolnierkiewicz
2020-02-10T16:50:31Z

On 2/4/20 5:55 PM, Hannes Reinecke wrote:
> All instances are gone.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/ata/libata-core.c | 2 --
> include/linux/libata.h | 5 -----
> 2 files changed, 7 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 0f1682a55b54..9c05177e09c2 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -6034,8 +6034,6 @@ struct ata_port *ata_port_alloc(struct ata_host *host)
> #if defined(ATA_VERBOSE_DEBUG)
> /* turn on all debugging levels */
> ap->msg_enable = 0x00FF;
> -#elif defined(ATA_DEBUG)
> - ap->msg_enable = ATA_MSG_DRV | ATA_MSG_WARN | ATA_MSG_ERR;
> #else
> ap->msg_enable = ATA_MSG_DRV | ATA_MSG_ERR | ATA_MSG_WARN;
> #endif
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 1012aed05187..06d6a3e18e18 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -38,22 +38,17 @@
> * compile-time options: to be removed as soon as all the drivers are
> * converted to the new debugging mechanism
> */
> -#undef ATA_DEBUG /* debugging output */
> #undef ATA_VERBOSE_DEBUG /* yet more debugging output */
> #undef ATA_IRQ_TRAP /* define to ack screaming irqs */
> #undef ATA_NDEBUG /* define to disable quick runtime checks */
>
>
> /* note: prints function name for you */
> -#ifdef ATA_DEBUG
> #ifdef ATA_VERBOSE_DEBUG
> #define VPRINTK(fmt, args...) printk(KERN_ERR "%s: " fmt, __func__, ## args)
> #else
> #define VPRINTK(fmt, args...)
> #endif /* ATA_VERBOSE_DEBUG */
> -#else
> -#define VPRINTK(fmt, args...)
> -#endif /* ATA_DEBUG */
>
> #define ata_print_version_once(dev, version) \
> ({ \
>