Re: [PATCH 27/46] sata_rcar: drop DPRINTK call in sata_rcar_exec_command()

Bartlomiej Zolnierkiewicz
2020-02-10T15:37:39Z

On 2/4/20 5:55 PM, Hannes Reinecke wrote:
> Is now logged with the generic tracepoint, so the DPRINTK call
> can be removed.

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

However please consider merging this patch with patch #25.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/ata/sata_rcar.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
> index 1b42be234761..0925a0564cc5 100644
> --- a/drivers/ata/sata_rcar.c
> +++ b/drivers/ata/sata_rcar.c
> @@ -436,8 +436,6 @@ static void sata_rcar_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
> static void sata_rcar_exec_command(struct ata_port *ap,
> const struct ata_taskfile *tf)
> {
> - DPRINTK("ata%u: cmd 0x%X\n", ap->print_id, tf->command);
> -
> iowrite32(tf->command, ap->ioaddr.command_addr);
> ata_sff_pause(ap);
> }
>