Re: [PATCH 24/46] libata: tracepoints for bus-master DMA

Bartlomiej Zolnierkiewicz
2020-02-10T15:23:10Z

On 2/10/20 4:21 PM, Bartlomiej Zolnierkiewicz wrote:
>
> On 2/4/20 5:55 PM, Hannes Reinecke wrote:
>> Add tracepoints for bus-master DMA and taskfile related functions.
>> That allows us to drop the relevant DPRINTK() calls.
>
> The patch drops VPRINTK() calls, not DPRINTK() ones.
Also there is a lot of complaints from checkpatch.pl script
regarding CodingStyle:

ERROR: space prohibited after that open parenthesis '('
#251: FILE: include/trace/events/libata.h:301:
+ __field( unsigned int, ata_port )

ERROR: space prohibited before that close parenthesis ')'
#251: FILE: include/trace/events/libata.h:301:
+ __field( unsigned int, ata_port )

ERROR: space prohibited after that open parenthesis '('
#252: FILE: include/trace/events/libata.h:302:
+ __field( unsigned char, cmd )

ERROR: space prohibited before that close parenthesis ')'
#252: FILE: include/trace/events/libata.h:302:
+ __field( unsigned char, cmd )

ERROR: space prohibited after that open parenthesis '('
#253: FILE: include/trace/events/libata.h:303:
+ __field( unsigned char, dev )

ERROR: space prohibited before that close parenthesis ')'
#253: FILE: include/trace/events/libata.h:303:
+ __field( unsigned char, dev )

ERROR: space prohibited after that open parenthesis '('
#254: FILE: include/trace/events/libata.h:304:
+ __field( unsigned char, lbal )

ERROR: space prohibited before that close parenthesis ')'
#254: FILE: include/trace/events/libata.h:304:
+ __field( unsigned char, lbal )

ERROR: space prohibited after that open parenthesis '('
#255: FILE: include/trace/events/libata.h:305:
+ __field( unsigned char, lbam )

ERROR: space prohibited before that close parenthesis ')'
#255: FILE: include/trace/events/libata.h:305:
+ __field( unsigned char, lbam )

ERROR: space prohibited after that open parenthesis '('
#256: FILE: include/trace/events/libata.h:306:
+ __field( unsigned char, lbah )

ERROR: space prohibited before that close parenthesis ')'
#256: FILE: include/trace/events/libata.h:306:
+ __field( unsigned char, lbah )

ERROR: space prohibited after that open parenthesis '('
#257: FILE: include/trace/events/libata.h:307:
+ __field( unsigned char, nsect )

ERROR: space prohibited before that close parenthesis ')'
#257: FILE: include/trace/events/libata.h:307:
+ __field( unsigned char, nsect )

ERROR: space prohibited after that open parenthesis '('
#258: FILE: include/trace/events/libata.h:308:
+ __field( unsigned char, feature )

ERROR: space prohibited before that close parenthesis ')'
#258: FILE: include/trace/events/libata.h:308:
+ __field( unsigned char, feature )

ERROR: space prohibited after that open parenthesis '('
#259: FILE: include/trace/events/libata.h:309:
+ __field( unsigned char, hob_lbal )

ERROR: space prohibited before that close parenthesis ')'
#259: FILE: include/trace/events/libata.h:309:
+ __field( unsigned char, hob_lbal )

ERROR: space prohibited after that open parenthesis '('
#260: FILE: include/trace/events/libata.h:310:
+ __field( unsigned char, hob_lbam )

ERROR: space prohibited before that close parenthesis ')'
#260: FILE: include/trace/events/libata.h:310:
+ __field( unsigned char, hob_lbam )

ERROR: space prohibited after that open parenthesis '('
#261: FILE: include/trace/events/libata.h:311:
+ __field( unsigned char, hob_lbah )

ERROR: space prohibited before that close parenthesis ')'
#261: FILE: include/trace/events/libata.h:311:
+ __field( unsigned char, hob_lbah )

ERROR: space prohibited after that open parenthesis '('
#262: FILE: include/trace/events/libata.h:312:
+ __field( unsigned char, hob_nsect )

ERROR: space prohibited before that close parenthesis ')'
#262: FILE: include/trace/events/libata.h:312:
+ __field( unsigned char, hob_nsect )

ERROR: space prohibited after that open parenthesis '('
#263: FILE: include/trace/events/libata.h:313:
+ __field( unsigned char, hob_feature )

ERROR: space prohibited before that close parenthesis ')'
#263: FILE: include/trace/events/libata.h:313:
+ __field( unsigned char, hob_feature )

ERROR: space prohibited after that open parenthesis '('
#264: FILE: include/trace/events/libata.h:314:
+ __field( unsigned char, proto )

ERROR: space prohibited before that close parenthesis ')'
#264: FILE: include/trace/events/libata.h:314:
+ __field( unsigned char, proto )

ERROR: space prohibited after that open parenthesis '('
#265: FILE: include/trace/events/libata.h:315:
+ __field( unsigned long, flags )

ERROR: space prohibited before that close parenthesis ')'
#265: FILE: include/trace/events/libata.h:315:
+ __field( unsigned long, flags )

WARNING: Avoid unnecessary line continuations
#285: FILE: include/trace/events/libata.h:335:
+ TP_printk("ata_port=%u proto=%s cmd=%s%s " \

WARNING: line over 80 characters
#290: FILE: include/trace/events/libata.h:340:
+ __parse_subcmd(__entry->cmd, __entry->feature, __entry->hob_nsect),

WARNING: line over 80 characters
#300: FILE: include/trace/events/libata.h:350:
+ TP_PROTO(struct ata_port *ap, const struct ata_taskfile *tf, unsigned int tag),

ERROR: space prohibited after that open parenthesis '('
#305: FILE: include/trace/events/libata.h:355:
+ __field( unsigned int, ata_port )

ERROR: space prohibited before that close parenthesis ')'
#305: FILE: include/trace/events/libata.h:355:
+ __field( unsigned int, ata_port )

ERROR: space prohibited after that open parenthesis '('
#306: FILE: include/trace/events/libata.h:356:
+ __field( unsigned int, tag )

ERROR: space prohibited before that close parenthesis ')'
#306: FILE: include/trace/events/libata.h:356:
+ __field( unsigned int, tag )

ERROR: space prohibited after that open parenthesis '('
#307: FILE: include/trace/events/libata.h:357:
+ __field( unsigned char, cmd )

ERROR: space prohibited before that close parenthesis ')'
#307: FILE: include/trace/events/libata.h:357:
+ __field( unsigned char, cmd )

ERROR: space prohibited after that open parenthesis '('
#308: FILE: include/trace/events/libata.h:358:
+ __field( unsigned char, proto )

ERROR: space prohibited before that close parenthesis ')'
#308: FILE: include/trace/events/libata.h:358:
+ __field( unsigned char, proto )

WARNING: line over 80 characters
#326: FILE: include/trace/events/libata.h:376:
+ TP_PROTO(struct ata_port *ap, const struct ata_taskfile *tf, unsigned int tag),

WARNING: line over 80 characters
#330: FILE: include/trace/events/libata.h:380:
+ TP_PROTO(struct ata_port *ap, const struct ata_taskfile *tf, unsigned int tag),

WARNING: line over 80 characters
#334: FILE: include/trace/events/libata.h:384:
+ TP_PROTO(struct ata_port *ap, const struct ata_taskfile *tf, unsigned int tag),

WARNING: line over 80 characters
#338: FILE: include/trace/events/libata.h:388:
+ TP_PROTO(struct ata_port *ap, const struct ata_taskfile *tf, unsigned int tag),

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics