Re: [PATCH 40/46] libata-eh: remove DPRINTK() calls for request sense

Bartlomiej Zolnierkiewicz
2020-02-10T16:46:23Z

On 2/4/20 5:55 PM, Hannes Reinecke wrote:
> The information will printed during ata_qc_issue() anyway, so
> this messages can be dropped.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/ata/libata-eh.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index f37dad5f9c17..388f8ed46eab 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1538,8 +1538,6 @@ static void ata_eh_request_sense(struct ata_queued_cmd *qc,
> return;
> }
>
> - DPRINTK("ATA request sense\n");
> -
> ata_tf_init(dev, &tf);
> tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE;
> tf.flags |= ATA_TFLAG_LBA | ATA_TFLAG_LBA48;
> @@ -1580,8 +1578,6 @@ unsigned int atapi_eh_request_sense(struct ata_device *dev,
> struct ata_port *ap = dev->link->ap;
> struct ata_taskfile tf;
>
> - DPRINTK("ATAPI request sense\n");
> -
> memset(sense_buf, 0, SCSI_SENSE_BUFFERSIZE);
>
> /* initialize sense_buf with the error register,
>