Re: [PATCH 20/46] sata_sil24: drop DPRINTK() calls in reset

Bartlomiej Zolnierkiewicz
2020-02-10T13:48:52Z

On 2/4/20 5:55 PM, Hannes Reinecke wrote:
> Reset is now logged with tracepoints, so the DPRINTK() calls can
> be dropped.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/ata/sata_sil24.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
> index 2373cf5d8d14..48e2b3ec2afd 100644
> --- a/drivers/ata/sata_sil24.c
> +++ b/drivers/ata/sata_sil24.c
> @@ -653,8 +653,6 @@ static int sil24_softreset(struct ata_link *link, unsigned int *class,
> const char *reason;
> int rc;
>
> - DPRINTK("ENTER\n");
> -
> /* put the port into known state */
> if (sil24_init_port(ap)) {
> reason = "port not ready";
> @@ -679,7 +677,6 @@ static int sil24_softreset(struct ata_link *link, unsigned int *class,
> sil24_read_tf(ap, 0, &tf);
> *class = ata_port_classify(ap, &tf);
>
> - DPRINTK("EXIT, class=%u\n", *class);
> return 0;
>
> err:
>