Re: [PATCH 37/46] pata_pdc2027x: Replace PDPRINTK() with standard ata logging

Bartlomiej Zolnierkiewicz
2020-02-10T15:59:41Z

On 2/4/20 5:55 PM, Hannes Reinecke wrote:
> From: Hannes Reinecke <hare@suse.com>
>
> Use standard ata logging macros instead of the hand-crafted
> PDPRINTK and remove duplicate logging messages.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>

It looks much better now, thank you for reworking it.

Could you please also fix some minor issues found by
checkpatch.pl script while at it:

WARNING: unnecessary whitespace before a quoted newline
#132: FILE: drivers/ata/pata_pdc2027x.c:300:
+ ata_port_dbg(ap, "Set pio regs... \n");

WARNING: unnecessary whitespace before a quoted newline
#143: FILE: drivers/ata/pata_pdc2027x.c:313:
+ ata_port_dbg(ap, "Set to pio mode[%u] \n", pio);

WARNING: unnecessary whitespace before a quoted newline
#152: FILE: drivers/ata/pata_pdc2027x.c:346:
+ ata_port_dbg(ap, "Set udma regs... \n");

WARNING: unnecessary whitespace before a quoted newline
#163: FILE: drivers/ata/pata_pdc2027x.c:355:
+ ata_port_dbg(ap, "Set to udma mode[%u] \n", udma_mode);

WARNING: unnecessary whitespace before a quoted newline
#171: FILE: drivers/ata/pata_pdc2027x.c:362:
+ ata_port_dbg(ap, "Set mdma regs... \n");

WARNING: unnecessary whitespace before a quoted newline
#182: FILE: drivers/ata/pata_pdc2027x.c:371:
+ ata_port_dbg(ap, "Set to mdma mode[%u] \n", mdma_mode);

?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/ata/pata_pdc2027x.c | 81 ++++++++++++++++++++-------------------------
> 1 file changed, 36 insertions(+), 45 deletions(-)
>
> diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c
> index de834fbb6dfe..2c397c135ccd 100644
> --- a/drivers/ata/pata_pdc2027x.c
> +++ b/drivers/ata/pata_pdc2027x.c
> @@ -30,13 +30,6 @@
>
> #define DRV_NAME "pata_pdc2027x"
> #define DRV_VERSION "1.0"
> -#undef PDC_DEBUG
> -
> -#ifdef PDC_DEBUG
> -#define PDPRINTK(fmt, args...) printk(KERN_ERR "%s: " fmt, __func__, ## args)
> -#else
> -#define PDPRINTK(fmt, args...)
> -#endif
>
> enum {
> PDC_MMIO_BAR = 5,
> @@ -214,11 +207,13 @@ static int pdc2027x_cable_detect(struct ata_port *ap)
> if (cgcr & (1 << 26))
> goto cbl40;
>
> - PDPRINTK("No cable or 80-conductor cable on port %d\n", ap->port_no);
> + ata_port_dbg(ap, "No cable or 80-conductor cable on port %d\n",
> + ap->port_no);
>
> return ATA_CBL_PATA80;
> cbl40:
> - printk(KERN_INFO DRV_NAME ": 40-conductor cable detected on port %d\n", ap->port_no);
> + ata_port_info(ap, "40-conductor cable detected on port %d\n",
> + ap->port_no);
> return ATA_CBL_PATA40;
> }
>
> @@ -292,17 +287,17 @@ static void pdc2027x_set_piomode(struct ata_port *ap, struct ata_device *adev)
> unsigned int pio = adev->pio_mode - XFER_PIO_0;
> u32 ctcr0, ctcr1;
>
> - PDPRINTK("adev->pio_mode[%X]\n", adev->pio_mode);
> + ata_port_dbg(ap, "adev->pio_mode[%X]\n", adev->pio_mode);
>
> /* Sanity check */
> if (pio > 4) {
> - printk(KERN_ERR DRV_NAME ": Unknown pio mode [%d] ignored\n", pio);
> + ata_port_err(ap, "Unknown pio mode [%d] ignored\n", pio);
> return;
>
> }
>
> /* Set the PIO timing registers using value table for 133MHz */
> - PDPRINTK("Set pio regs... \n");
> + ata_port_dbg(ap, "Set pio regs... \n");
>
> ctcr0 = ioread32(dev_mmio(ap, adev, PDC_CTCR0));
> ctcr0 &= 0xffff0000;
> @@ -315,9 +310,7 @@ static void pdc2027x_set_piomode(struct ata_port *ap, struct ata_device *adev)
> ctcr1 |= (pdc2027x_pio_timing_tbl[pio].value2 << 24);
> iowrite32(ctcr1, dev_mmio(ap, adev, PDC_CTCR1));
>
> - PDPRINTK("Set pio regs done\n");
> -
> - PDPRINTK("Set to pio mode[%u] \n", pio);
> + ata_port_dbg(ap, "Set to pio mode[%u] \n", pio);
> }
>
> /**
> @@ -350,7 +343,7 @@ static void pdc2027x_set_dmamode(struct ata_port *ap, struct ata_device *adev)
> iowrite32(ctcr1 & ~(1 << 7), dev_mmio(ap, adev, PDC_CTCR1));
> }
>
> - PDPRINTK("Set udma regs... \n");
> + ata_port_dbg(ap, "Set udma regs... \n");
>
> ctcr1 = ioread32(dev_mmio(ap, adev, PDC_CTCR1));
> ctcr1 &= 0xff000000;
> @@ -359,16 +352,14 @@ static void pdc2027x_set_dmamode(struct ata_port *ap, struct ata_device *adev)
> (pdc2027x_udma_timing_tbl[udma_mode].value2 << 16);
> iowrite32(ctcr1, dev_mmio(ap, adev, PDC_CTCR1));
>
> - PDPRINTK("Set udma regs done\n");
> -
> - PDPRINTK("Set to udma mode[%u] \n", udma_mode);
> + ata_port_dbg(ap, "Set to udma mode[%u] \n", udma_mode);
>
> } else if ((dma_mode >= XFER_MW_DMA_0) &&
> (dma_mode <= XFER_MW_DMA_2)) {
> /* Set the MDMA timing registers with value table for 133MHz */
> unsigned int mdma_mode = dma_mode & 0x07;
>
> - PDPRINTK("Set mdma regs... \n");
> + ata_port_dbg(ap, "Set mdma regs... \n");
> ctcr0 = ioread32(dev_mmio(ap, adev, PDC_CTCR0));
>
> ctcr0 &= 0x0000ffff;
> @@ -376,11 +367,10 @@ static void pdc2027x_set_dmamode(struct ata_port *ap, struct ata_device *adev)
> (pdc2027x_mdma_timing_tbl[mdma_mode].value1 << 24);
>
> iowrite32(ctcr0, dev_mmio(ap, adev, PDC_CTCR0));
> - PDPRINTK("Set mdma regs done\n");
>
> - PDPRINTK("Set to mdma mode[%u] \n", mdma_mode);
> + ata_port_dbg(ap, "Set to mdma mode[%u] \n", mdma_mode);
> } else {
> - printk(KERN_ERR DRV_NAME ": Unknown dma mode [%u] ignored\n", dma_mode);
> + ata_port_err(ap, "Unknown dma mode [%u] ignored\n", dma_mode);
> }
> }
>
> @@ -414,7 +404,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct ata_device **r_failed
> ctcr1 |= (1 << 25);
> iowrite32(ctcr1, dev_mmio(ap, dev, PDC_CTCR1));
>
> - PDPRINTK("Turn on prefetch\n");
> + ata_dev_dbg(dev, "Turn on prefetch\n");
> } else {
> pdc2027x_set_dmamode(ap, dev);
> }
> @@ -485,8 +475,10 @@ static long pdc_read_counter(struct ata_host *host)
>
> counter = (bccrh << 15) | bccrl;
>
> - PDPRINTK("bccrh [%X] bccrl [%X]\n", bccrh, bccrl);
> - PDPRINTK("bccrhv[%X] bccrlv[%X]\n", bccrhv, bccrlv);
> + dev_dbg(host->dev, "%s: bccrh [%X] bccrl [%X]\n",
> + __func__, bccrh, bccrl);
> + dev_dbg(host->dev, "%s: bccrhv[%X] bccrlv[%X]\n",
> + __func__, bccrhv, bccrlv);
>
> /*
> * The 30-bit decreasing counter are read by 2 pieces.
> @@ -495,7 +487,7 @@ static long pdc_read_counter(struct ata_host *host)
> */
> if (retry && !(bccrh == bccrhv && bccrl >= bccrlv)) {
> retry--;
> - PDPRINTK("rereading counter\n");
> + dev_dbg(host->dev, "%s: rereading counter\n", __func__);
> goto retry;
> }
>
> @@ -520,20 +512,21 @@ static void pdc_adjust_pll(struct ata_host *host, long pll_clock, unsigned int b
>
> /* Sanity check */
> if (unlikely(pll_clock_khz < 5000L || pll_clock_khz > 70000L)) {
> - printk(KERN_ERR DRV_NAME ": Invalid PLL input clock %ldkHz, give up!\n", pll_clock_khz);
> + dev_err(host->dev,
> + "Invalid PLL input clock %ldkHz, give up!\n",
> + pll_clock_khz);
> return;
> }
>
> -#ifdef PDC_DEBUG
> - PDPRINTK("pout_required is %ld\n", pout_required);
> + dev_dbg(host->dev, "%s: pout_required is %ld\n",
> + __func__, pout_required);
>
> /* Show the current clock value of PLL control register
> * (maybe already configured by the firmware)
> */
> pll_ctl = ioread16(mmio_base + PDC_PLL_CTL);
>
> - PDPRINTK("pll_ctl[%X]\n", pll_ctl);
> -#endif
> + dev_dbg(host->dev, "%s: pll_ctl[%X]\n", __func__, pll_ctl);
>
> /*
> * Calculate the ratio of F, R and OD
> @@ -552,7 +545,7 @@ static void pdc_adjust_pll(struct ata_host *host, long pll_clock, unsigned int b
> R = 0x00;
> } else {
> /* Invalid ratio */
> - printk(KERN_ERR DRV_NAME ": Invalid ratio %ld, give up!\n", ratio);
> + dev_err(host->dev, "Invalid ratio %ld, give up!\n", ratio);
> return;
> }
>
> @@ -560,15 +553,16 @@ static void pdc_adjust_pll(struct ata_host *host, long pll_clock, unsigned int b
>
> if (unlikely(F < 0 || F > 127)) {
> /* Invalid F */
> - printk(KERN_ERR DRV_NAME ": F[%d] invalid!\n", F);
> + dev_err(host->dev, "F[%d] invalid!\n", F);
> return;
> }
>
> - PDPRINTK("F[%d] R[%d] ratio*1000[%ld]\n", F, R, ratio);
> + dev_dbg(host->dev, "%s: F[%d] R[%d] ratio*1000[%ld]\n",
> + __func__, F, R, ratio);
>
> pll_ctl = (R << 8) | F;
>
> - PDPRINTK("Writing pll_ctl[%X]\n", pll_ctl);
> + dev_dbg(host->dev, "%s: Writing pll_ctl[%X]\n", __func__, pll_ctl);
>
> iowrite16(pll_ctl, mmio_base + PDC_PLL_CTL);
> ioread16(mmio_base + PDC_PLL_CTL); /* flush */
> @@ -576,15 +570,12 @@ static void pdc_adjust_pll(struct ata_host *host, long pll_clock, unsigned int b
> /* Wait the PLL circuit to be stable */
> msleep(30);
>
> -#ifdef PDC_DEBUG
> /*
> * Show the current clock value of PLL control register
> * (maybe configured by the firmware)
> */
> - pll_ctl = ioread16(mmio_base + PDC_PLL_CTL);
> -
> - PDPRINTK("pll_ctl[%X]\n", pll_ctl);
> -#endif
> + dev_dbg(host->dev, "%s: pll_ctl[%X]\n", __func__,
> + ioread16(mmio_base + PDC_PLL_CTL));
>
> return;
> }
> @@ -605,7 +596,7 @@ static long pdc_detect_pll_input_clock(struct ata_host *host)
>
> /* Start the test mode */
> scr = ioread32(mmio_base + PDC_SYS_CTL);
> - PDPRINTK("scr[%X]\n", scr);
> + dev_dbg(host->dev, "%s: scr[%X]\n", __func__, scr);
> iowrite32(scr | (0x01 << 14), mmio_base + PDC_SYS_CTL);
> ioread32(mmio_base + PDC_SYS_CTL); /* flush */
>
> @@ -622,7 +613,7 @@ static long pdc_detect_pll_input_clock(struct ata_host *host)
>
> /* Stop the test mode */
> scr = ioread32(mmio_base + PDC_SYS_CTL);
> - PDPRINTK("scr[%X]\n", scr);
> + dev_dbg(host->dev, "%s: scr[%X]\n", __func__, scr);
> iowrite32(scr & ~(0x01 << 14), mmio_base + PDC_SYS_CTL);
> ioread32(mmio_base + PDC_SYS_CTL); /* flush */
>
> @@ -632,8 +623,8 @@ static long pdc_detect_pll_input_clock(struct ata_host *host)
> pll_clock = ((start_count - end_count) & 0x3fffffff) / 100 *
> (100000000 / usec_elapsed);
>
> - PDPRINTK("start[%ld] end[%ld] \n", start_count, end_count);
> - PDPRINTK("PLL input clock[%ld]Hz\n", pll_clock);
> + dev_dbg(host->dev, "%s: start[%ld] end[%ld] PLL input clock[%ld]HZ\n",
> + __func__, start_count, end_count, pll_clock);
>
> return pll_clock;
> }
>