Re: [PATCH 12/46] sata_sx4: move DPRINTK to VPRINTK

Bartlomiej Zolnierkiewicz
2020-02-10T13:29:28Z

On 2/4/20 5:55 PM, Hannes Reinecke wrote:
> From: Hannes Reinecke <hare@suse.com>
>
> All other logging instances in this functions are with VPRINTK,
> so follow suit.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>

Please fix From: and S-o-B: to match (some other patches also
have this issue).

With that resolved:

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/ata/sata_sx4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/sata_sx4.c b/drivers/ata/sata_sx4.c
> index 2c7b30c5ea3d..e99d9f5139f9 100644
> --- a/drivers/ata/sata_sx4.c
> +++ b/drivers/ata/sata_sx4.c
> @@ -755,7 +755,7 @@ static inline unsigned int pdc20621_host_intr(struct ata_port *ap,
> } else if (qc->tf.protocol == ATA_PROT_NODATA) {
>
> status = ata_sff_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000);
> - DPRINTK("BUS_NODATA (drv_stat 0x%X)\n", status);
> + VPRINTK("BUS_NODATA (drv_stat 0x%X)\n", status);
> qc->err_mask |= ac_err_mask(status);
> ata_qc_complete(qc);
> handled = 1;
>