Re: [PATCH 15/46] ahci: drop DPRINTK() calls in reset

Bartlomiej Zolnierkiewicz
2020-02-10T13:43:53Z

On 2/4/20 5:55 PM, Hannes Reinecke wrote:
> Reset is now logged with tracepoints, so the DPRINTK() calls can
> be dropped.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/ata/ahci.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 4f628e33f52e..56066cb4506f 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -683,8 +683,6 @@ static int ahci_vt8251_hardreset(struct ata_link *link, unsigned int *class,
> bool online;
> int rc;
>
> - DPRINTK("ENTER\n");
> -
> hpriv->stop_engine(ap);
>
> rc = sata_link_hardreset(link, sata_ehc_deb_timing(&link->eh_context),
> @@ -692,8 +690,6 @@ static int ahci_vt8251_hardreset(struct ata_link *link, unsigned int *class,
>
> hpriv->start_engine(ap);
>
> - DPRINTK("EXIT, rc=%d, class=%u\n", rc, *class);
> -
> /* vt8251 doesn't clear BSY on signature FIS reception,
> * request follow-up softreset.
> */
> @@ -773,8 +769,6 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class,
> bool online;
> int rc, i;
>
> - DPRINTK("ENTER\n");
> -
> hpriv->stop_engine(ap);
>
> for (i = 0; i < 2; i++) {
> @@ -812,7 +806,6 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class,
> if (online)
> *class = ahci_dev_classify(ap);
>
> - DPRINTK("EXIT, rc=%d, class=%u\n", rc, *class);
> return rc;
> }
>