Re: [PATCH 08/46] libata: Add ata_port_classify() helper

Hannes Reinecke
2020-02-13T07:15:58Z

On 2/10/20 1:44 PM, Bartlomiej Zolnierkiewicz wrote:
>
> On 2/4/20 5:55 PM, Hannes Reinecke wrote:
>> Add an ata_port_classify() helper to print out the results from
>> the device classification and remove the debugging statements
>> from ata_dev_classify(). Also provide a mapping ata_dev_class_string()
>> to provide a string representation for those instances calling
>> ata_dev_classify() directly.
>>
>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>> ---
>> drivers/ata/libahci.c | 2 +-
>> drivers/ata/libata-core.c | 68 ++++++++++++++++++++++++++++++++++-----------
>> drivers/ata/libata-sff.c | 5 ++++
>> drivers/ata/sata_fsl.c | 2 +-
>> drivers/ata/sata_inic162x.c | 2 +-
>> drivers/ata/sata_sil24.c | 2 +-
>> include/linux/libata.h | 3 ++
>> 7 files changed, 64 insertions(+), 20 deletions(-)
>>
[ .. ]
>> @@ -7267,6 +7301,7 @@ EXPORT_SYMBOL_GPL(ata_xfer_mask2mode);
>> EXPORT_SYMBOL_GPL(ata_xfer_mode2mask);
>> EXPORT_SYMBOL_GPL(ata_xfer_mode2shift);
>> EXPORT_SYMBOL_GPL(ata_mode_string);
>> +EXPORT_SYMBOL_GPL(ata_dev_class_string);
>
> This is not needed currently, please remove it.
>
Okay, will do.

> Also EXPORT_SYMBOL_GPL() for ata_dev_classify() should be now
> removed too.
>
No, we can't, as it's being used in drivers/scsi/libsas/sas_ata.c.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer