Re: [PATCH 22/46] libata-core: drop DPRINTK() calls in reset

Bartlomiej Zolnierkiewicz
2020-02-10T13:50:34Z

On 2/4/20 5:55 PM, Hannes Reinecke wrote:
> Reset is now logged with tracepoints, so the DPRINTK() calls can
> be dropped.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/ata/libata-core.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 8a18047f9bcb..297aa8172d4e 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4070,8 +4070,6 @@ int sata_link_hardreset(struct ata_link *link, const unsigned long *timing,
> u32 scontrol;
> int rc;
>
> - DPRINTK("ENTER\n");
> -
> if (online)
> *online = false;
>
> @@ -4147,7 +4145,6 @@ int sata_link_hardreset(struct ata_link *link, const unsigned long *timing,
> *online = false;
> ata_link_err(link, "COMRESET failed (errno=%d)\n", rc);
> }
> - DPRINTK("EXIT, rc=%d\n", rc);
> return rc;
> }
>
> @@ -4193,16 +4190,12 @@ void ata_std_postreset(struct ata_link *link, unsigned int *classes)
> {
> u32 serror;
>
> - DPRINTK("ENTER\n");
> -
> /* reset complete, clear SError */
> if (!sata_scr_read(link, SCR_ERROR, &serror))
> sata_scr_write(link, SCR_ERROR, serror);
>
> /* print link status */
> sata_print_link_status(link);
> -
> - DPRINTK("EXIT\n");
> }
>
> /**
>