From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F47C433E0 for ; Tue, 16 Jun 2020 22:04:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 892F920C09 for ; Tue, 16 Jun 2020 22:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592345095; bh=zZ4bUdq2K5ojEsFNwkT75BRnNvTH2SiQYaGdmtmA+LY=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=OjBralQU5mCL9aRDuzsAO8LLb9wtu3kdR2vV8a3jrW7RfjNyDivvt6OMHi2juWeOC lcmd1J1ajS9He2eZhu1X+4/PrjMmErxNJhvwrcwJT5x0/ji2hw7DxYYDbys+buL1zN Tb9KeJtPfd0ZMKfi/lTIgVnQ55eQAxghUViE8W20= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726506AbgFPWEz (ORCPT ); Tue, 16 Jun 2020 18:04:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:46716 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbgFPWEz (ORCPT ); Tue, 16 Jun 2020 18:04:55 -0400 Received: from localhost (mobile-166-170-222-206.mycingular.net [166.170.222.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1217D2098B; Tue, 16 Jun 2020 22:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592345094; bh=zZ4bUdq2K5ojEsFNwkT75BRnNvTH2SiQYaGdmtmA+LY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=dd7DDppHgktg8e8KtkNmGEBjAzou4NJtHhshd5D5iXcW+leO25FXNxXDZWnY2I0Bk YrxOpMwfKTfQ2ieFXVvDjA9DHKagBo5wTtub2FYwA+pxC4gHs4II2F9118TPhU0NwW CEOrkYO+kNqRG1mP0l0R1uk+nRVtuDAWkJ2JD1zA= Date: Tue, 16 Jun 2020 17:04:51 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Christoph Hellwig , Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, Jens Axboe , Philipp Zabel , Florian Fainelli , Hans de Goede , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , open list Subject: Re: [PATCH v5 02/12] ata: ahci_brcm: Fix use of BCM7216 reset controller Message-ID: <20200616220451.GA1983693@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200616205533.3513-3-james.quinlan@broadcom.com> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Tue, Jun 16, 2020 at 04:55:09PM -0400, Jim Quinlan wrote: > From: Jim Quinlan > > A reset controller "rescal" is shared between the AHCI driver and the PCIe > driver for the BrcmSTB 7216 chip. The code is modified to allow this > sharing and to deassert() properly. Use imperative mood, e.g., A reset controller "rescal" is shared between the AHCI driver and the PCIe driver for the BrcmSTB 7216 chip. Use devm_reset_control_get_optional_shared control() to handle this sharing. > Signed-off-by: Jim Quinlan > > Fixes: 272ecd60a636 ("ata: ahci_brcm: BCM7216 reset is self de-asserting") > Fixes: c345ec6a50e9 ("ata: ahci_brcm: Support BCM7216 reset controller > name") Don't wrap "Fixes:" lines so it's easier to search for them.