From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32064C433E6 for ; Tue, 2 Feb 2021 09:33:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF20C64EE4 for ; Tue, 2 Feb 2021 09:33:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232658AbhBBJdj (ORCPT ); Tue, 2 Feb 2021 04:33:39 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:53684 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231601AbhBBJdM (ORCPT ); Tue, 2 Feb 2021 04:33:12 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id AEB9F1C0B76; Tue, 2 Feb 2021 10:32:29 +0100 (CET) Date: Tue, 2 Feb 2021 10:32:29 +0100 From: Pavel Machek To: Hans de Goede Cc: Jens Axboe , Dan Murphy , linux-ide@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: 5.11 new lockdep warning related to led-class code (also may involve ata / piix controller) Message-ID: <20210202093228.GA29131@amd> References: <20210112223015.GB28214@duo.ucw.cz> <0ec34bca-f7e0-8954-c253-d07ed6b71b80@redhat.com> <20210127220134.GC23419@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Is it a regression? AFAIK it is a bug that has been there > > forever... My original plan was to simply wait for 5.12, so it gets > > full release of testing... >=20 > It may have been a pre-existing bug which got triggered by libata > changes? Fixes tag suggests it is rather old. > I don't know. I almost always run all my locally build kernels with lockd= ep > enabled and as the maintainer of the vboxvideo, vboxguest and vboxsf guest > drivers in the mainline kernel I quite often boot local build kernels ins= ide > a vm. >=20 > So I believe that lockdep tripping over this is new in 5.11, which is why > I called it a regression. >=20 > And the fix seems very safe and simple, so IMHO it would be good to get > this into 5.11 It is in 5.11 now, and also -stable kernels. (Which suprised me a bit). Testing would be welcome. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmAZHCwACgkQMOfwapXb+vJIhwCffqEyb87hmw489lVr2xJf68p9 s4gAnjqioizHCLkcak/HHiwFMBgzwn19 =kcnu -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/--