* [PATCH RESEND][next] ide: Fix fall-through warnings for Clang
@ 2021-03-05 10:00 Gustavo A. R. Silva
2021-04-20 20:11 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 10:00 UTC (permalink / raw)
To: David S. Miller
Cc: linux-ide, linux-kernel, Gustavo A. R. Silva, linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/ide/siimage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ide/siimage.c b/drivers/ide/siimage.c
index 198847488cc6..c190dc6dfb50 100644
--- a/drivers/ide/siimage.c
+++ b/drivers/ide/siimage.c
@@ -493,6 +493,7 @@ static int init_chipset_siimage(struct pci_dev *dev)
case 0x30:
/* Clocking is disabled, attempt to force 133MHz clocking. */
sil_iowrite8(dev, tmp & ~0x20, scsc_addr);
+ break;
case 0x10:
/* On 133Mhz clocking. */
break;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND][next] ide: Fix fall-through warnings for Clang
2021-03-05 10:00 [PATCH RESEND][next] ide: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-04-20 20:11 ` Gustavo A. R. Silva
2021-05-18 0:54 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-04-20 20:11 UTC (permalink / raw)
To: Gustavo A. R. Silva, David S. Miller
Cc: linux-ide, linux-kernel, linux-hardening
Hi all,
Friendly ping: who can take this, please?
Thanks
--
Gustavo
On 3/5/21 04:00, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/ide/siimage.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ide/siimage.c b/drivers/ide/siimage.c
> index 198847488cc6..c190dc6dfb50 100644
> --- a/drivers/ide/siimage.c
> +++ b/drivers/ide/siimage.c
> @@ -493,6 +493,7 @@ static int init_chipset_siimage(struct pci_dev *dev)
> case 0x30:
> /* Clocking is disabled, attempt to force 133MHz clocking. */
> sil_iowrite8(dev, tmp & ~0x20, scsc_addr);
> + break;
> case 0x10:
> /* On 133Mhz clocking. */
> break;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND][next] ide: Fix fall-through warnings for Clang
2021-04-20 20:11 ` Gustavo A. R. Silva
@ 2021-05-18 0:54 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-18 0:54 UTC (permalink / raw)
To: Gustavo A. R. Silva, David S. Miller
Cc: linux-ide, linux-kernel, linux-hardening
Hi all,
If you don't mind, I'm taking this in my -next[1] branch for v5.14.
Thanks
--
Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
On 4/20/21 15:11, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 3/5/21 04:00, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>> drivers/ide/siimage.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/ide/siimage.c b/drivers/ide/siimage.c
>> index 198847488cc6..c190dc6dfb50 100644
>> --- a/drivers/ide/siimage.c
>> +++ b/drivers/ide/siimage.c
>> @@ -493,6 +493,7 @@ static int init_chipset_siimage(struct pci_dev *dev)
>> case 0x30:
>> /* Clocking is disabled, attempt to force 133MHz clocking. */
>> sil_iowrite8(dev, tmp & ~0x20, scsc_addr);
>> + break;
>> case 0x10:
>> /* On 133Mhz clocking. */
>> break;
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-18 0:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-05 10:00 [PATCH RESEND][next] ide: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:11 ` Gustavo A. R. Silva
2021-05-18 0:54 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).