From: Hannes Reinecke <hare@suse.de>
To: Damien LeMoal <damien.lemoal@wdc.com>
Cc: linux-ide@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 58/68] sata_sx4: convert printk() calls
Date: Fri, 10 Dec 2021 08:28:55 +0100 [thread overview]
Message-ID: <20211210072905.15666-59-hare@suse.de> (raw)
In-Reply-To: <20211210072905.15666-1-hare@suse.de>
Convert printk() calls to structured logging.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/ata/sata_sx4.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/sata_sx4.c b/drivers/ata/sata_sx4.c
index 5d7913644dfc..6ceec59cb291 100644
--- a/drivers/ata/sata_sx4.c
+++ b/drivers/ata/sata_sx4.c
@@ -1179,15 +1179,16 @@ static unsigned int pdc20621_prog_dimm_global(struct ata_host *host)
/* Turn on for ECC */
if (!pdc20621_i2c_read(host, PDC_DIMM0_SPD_DEV_ADDRESS,
PDC_DIMM_SPD_TYPE, &spd0)) {
- pr_err("Failed in i2c read: device=%#x, subaddr=%#x\n",
- PDC_DIMM0_SPD_DEV_ADDRESS, PDC_DIMM_SPD_TYPE);
+ dev_err(host->dev,
+ "Failed in i2c read: device=%#x, subaddr=%#x\n",
+ PDC_DIMM0_SPD_DEV_ADDRESS, PDC_DIMM_SPD_TYPE);
return 1;
}
if (spd0 == 0x02) {
data |= (0x01 << 16);
writel(data, mmio + PDC_SDRAM_CONTROL);
readl(mmio + PDC_SDRAM_CONTROL);
- printk(KERN_ERR "Local DIMM ECC Enabled\n");
+ dev_err(host->dev, "Local DIMM ECC Enabled\n");
}
/* DIMM Initialization Select/Enable (bit 18/19) */
@@ -1279,7 +1280,7 @@ static unsigned int pdc20621_dimm_init(struct ata_host *host)
and program the DIMM Module Controller.
*/
if (!(speed = pdc20621_detect_dimm(host))) {
- printk(KERN_ERR "Detect Local DIMM Fail\n");
+ dev_err(host->dev, "Detect Local DIMM Fail\n");
return 1; /* DIMM error */
}
dev_dbg(host->dev, "Local DIMM Speed = %d\n", speed);
--
2.29.2
next prev parent reply other threads:[~2021-12-10 7:29 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 7:27 [PATCHv2 00/68] libata: rework logging, take II Hannes Reinecke
2021-12-10 7:27 ` [PATCH 01/68] libata: remove pointless debugging messages Hannes Reinecke
2021-12-10 7:27 ` [PATCH 02/68] libata: whitespace cleanup Hannes Reinecke
2021-12-10 7:28 ` [PATCH 03/68] libata: Add ata_port_classify() helper Hannes Reinecke
2021-12-10 7:28 ` [PATCH 04/68] libata: move ata_dump_id() to dynamic debugging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 05/68] libata: sanitize ATA_HORKAGE_DUMP_ID Hannes Reinecke
2021-12-10 7:28 ` [PATCH 06/68] libata: add reset tracepoints Hannes Reinecke
2021-12-10 7:28 ` [PATCH 07/68] libata: add qc_prep tracepoint Hannes Reinecke
2021-12-10 7:28 ` [PATCH 08/68] libata: tracepoints for bus-master DMA Hannes Reinecke
2021-12-10 7:28 ` [PATCH 09/68] libata-sff: tracepoints for HSM state machine Hannes Reinecke
2021-12-10 7:28 ` [PATCH 10/68] libata-scsi: drop DPRINTK calls for cdb translation Hannes Reinecke
2021-12-10 7:28 ` [PATCH 11/68] libata: add tracepoints for ATA error handling Hannes Reinecke
2021-12-10 7:28 ` [PATCH 12/68] libata: move ata_{port,link,dev}_dbg to standard dev_XXX() macros Hannes Reinecke
2021-12-10 7:28 ` [PATCH 13/68] libata: revamp ata_get_cmd_descript() Hannes Reinecke
2021-12-12 9:33 ` Sergey Shtylyov
2021-12-10 7:28 ` [PATCH 14/68] libata: move DPRINTK to ata debugging Hannes Reinecke
2021-12-12 9:36 ` Sergey Shtylyov
2021-12-10 7:28 ` [PATCH 15/68] sata_mv: kill 'port' argument in mv_dump_all_regs() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 16/68] sata_mv: replace DPRINTK with dynamic debugging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 17/68] pata_octeon_cf: remove DPRINTK() macro in interrupt context Hannes Reinecke
2021-12-10 7:28 ` [PATCH 18/68] pdc_adma: Remove DPRINTK call Hannes Reinecke
2021-12-10 7:28 ` [PATCH 19/68] sata_fsl: move DPRINTK to ata debugging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 20/68] sata_rcar: replace DPRINTK() with ata_port_dbg() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 21/68] sata_qstor: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 22/68] pata_pdc2027x: Replace PDPRINTK() with standard ata logging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 23/68] libata: remove pointless VPRINTK() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 24/68] ahci: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-10 7:28 ` [PATCH 25/68] pdc_adma: Drop pointless VPRINTK() calls and remove disabled NCQ debugging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 26/68] pata_octeon_cf: Drop pointless VPRINTK() calls and convert the remaining one Hannes Reinecke
2021-12-12 9:23 ` Sergey Shtylyov
2021-12-10 7:28 ` [PATCH 27/68] pata_via: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 28/68] sata_promise: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-10 16:19 ` Mikael Pettersson
2021-12-12 9:52 ` Sergey Shtylyov
2021-12-10 7:28 ` [PATCH 29/68] sata_qstor: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 30/68] sata_rcar: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 31/68] sata_inic162x: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 32/68] sata_mv: Drop pointless VPRINTK() call and convert the remaining one Hannes Reinecke
2021-12-10 7:28 ` [PATCH 33/68] sata_nv: drop pointless VPRINTK() calls and convert remaining ones Hannes Reinecke
2021-12-10 7:28 ` [PATCH 34/68] sata_fsl: convert VPRINTK() calls to ata_port_dbg() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 35/68] sata_sil: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 36/68] sata_sx4: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-10 7:28 ` [PATCH 37/68] sata_sx4: add module parameter 'dimm_test' Hannes Reinecke
2021-12-10 7:28 ` [PATCH 38/68] libata: drop ata_msg_error() and ata_msg_intr() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 39/68] libata: drop ata_msg_ctl() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 40/68] libata: drop ata_msg_malloc() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 41/68] libata: drop ata_msg_warn() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 42/68] libata: drop ata_msg_probe() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 43/68] libata: drop ata_msg_info() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 44/68] libata: drop ata_msg_drv() Hannes Reinecke
2021-12-10 7:28 ` [PATCH 45/68] libata: remove 'new' ata message handling Hannes Reinecke
2021-12-10 7:28 ` [PATCH 46/68] libata: remove debug compilation switches Hannes Reinecke
2021-12-12 9:21 ` Sergey Shtylyov
2021-12-10 7:28 ` [PATCH 47/68] pata_atp867x: convert printk() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 48/68] pata_cmd640: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 49/68] pata_cmd64x: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 50/68] pata_cs5520: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 51/68] pata_cs5536: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 52/68] pata_cypress: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 53/68] pata_it821x: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 54/68] pata_marvell: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 55/68] pata_rz1000: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 56/68] pata_serverworks: " Hannes Reinecke
2021-12-10 7:28 ` [PATCH 57/68] pata_sil680: " Hannes Reinecke
2021-12-10 7:28 ` Hannes Reinecke [this message]
2021-12-10 7:28 ` [PATCH 59/68] sata_mv: convert remaining printk() to structured logging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 60/68] pata_hpt37x: convert pr_XXX() calls Hannes Reinecke
2021-12-10 7:28 ` [PATCH 61/68] pata_octeon_cf: Replace pr_XXX() calls with structured logging Hannes Reinecke
2021-12-10 7:28 ` [PATCH 62/68] pata_hpt3x2n: convert pr_XXX() calls Hannes Reinecke
2021-12-10 7:29 ` [PATCH 63/68] sata_gemini: convert pr_err() calls Hannes Reinecke
2021-12-10 7:29 ` [PATCH 64/68] pata_hpt366: convert pr_warn() calls Hannes Reinecke
2021-12-10 7:29 ` [PATCH 65/68] libata-scsi: rework ata_dump_status to avoid using pr_cont() Hannes Reinecke
2021-12-10 7:29 ` [PATCH 66/68] sata_dwc_460ex: drop DEBUG_NCQ Hannes Reinecke
2021-12-10 7:29 ` [PATCH 67/68] sata_dwc_460ex: remove 'checkstatus' argument Hannes Reinecke
2021-12-12 9:18 ` Sergey Shtylyov
2021-12-10 7:29 ` [PATCH 68/68] sata_dwc_460ex: Remove debug compile options Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2021-12-21 7:20 [PATCHv3 00/68] libata: rework logging, take II Hannes Reinecke
2021-12-21 7:21 ` [PATCH 58/68] sata_sx4: convert printk() calls Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211210072905.15666-59-hare@suse.de \
--to=hare@suse.de \
--cc=damien.lemoal@wdc.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).