From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DED8C433F5 for ; Tue, 15 Feb 2022 04:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229498AbiBOEyp (ORCPT ); Mon, 14 Feb 2022 23:54:45 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232367AbiBOEyp (ORCPT ); Mon, 14 Feb 2022 23:54:45 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AF10C5D84; Mon, 14 Feb 2022 20:54:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644900875; x=1676436875; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ToPYTSKqgT3dHAF94OVKr+aABefwhPvEIXV8gTUWHE4=; b=OJ5mlsxKVhXToEKmGwx3L2WnzhZbXXTRi6YWelSyddUA76r4a3KGgKXF lFc8Q+5060DwaCVSqiZPONaWV53XyMx6OHQdk9pNzpRuuS0VpBkUmaqQY MFE7K+PqxE9AaJWbzD0iYpN/YYA/FFbhXM+Up17YmfoDLN9nWiT6y1OhU 3ucT2aJ/MwWZmM+NS6HhoF7BD66jF6/o43n0fciyibJ8b5ZSPI4KTLSoA kItC/TW9C2gCANf6v7TyqdPDUBwTxZqzkdGNDyn7W11ccwnh7L2bnpQ7v 94p8BDB/hBA8d7LthCddVzuFA10JObYJOGUQJQnCs1kBPg31IpgTfGIfw g==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="247844134" X-IronPort-AV: E=Sophos;i="5.88,369,1635231600"; d="scan'208";a="247844134" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 20:54:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,369,1635231600"; d="scan'208";a="570633505" Received: from lkp-server01.sh.intel.com (HELO d95dc2dabeb1) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 14 Feb 2022 20:54:33 -0800 Received: from kbuild by d95dc2dabeb1 with local (Exim 4.92) (envelope-from ) id 1nJprF-0009Hr-1g; Tue, 15 Feb 2022 04:54:33 +0000 Date: Tue, 15 Feb 2022 12:54:20 +0800 From: kernel test robot To: Sergey Shtylyov , Damien Le Moal , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org Subject: Re: [PATCH] ata: add/use ata_taskfile::{error|status} fields Message-ID: <202202151209.hSVAcH7A-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Hi Sergey, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.17-rc4 next-20220214] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sergey-Shtylyov/ata-add-use-ata_taskfile-error-status-fields/20220215-044836 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d567f5db412ed52de0b3b3efca4a451263de6108 config: i386-buildonly-randconfig-r006-20220214 (https://download.01.org/0day-ci/archive/20220215/202202151209.hSVAcH7A-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 37f422f4ac31c8b8041c6b62065263314282dab6) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/5d89e7cd8ab42fd2cb6f59a7922784b0cce835bf git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sergey-Shtylyov/ata-add-use-ata_taskfile-error-status-fields/20220215-044836 git checkout 5d89e7cd8ab42fd2cb6f59a7922784b0cce835bf # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ata/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/ata/sata_vsc.c:203:21: error: use of undeclared identifier 'feature'; did you mean 'return'? tf->hob_feature = feature >> 8; ^~~~~~~ return >> drivers/ata/sata_vsc.c:203:21: error: expected expression 2 errors generated. vim +203 drivers/ata/sata_vsc.c ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 181 ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 182 ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 183 static void vsc_sata_tf_read(struct ata_port *ap, struct ata_taskfile *tf) ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 184 { ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 185 struct ata_ioports *ioaddr = &ap->ioaddr; 5d89e7cd8ab42f drivers/ata/sata_vsc.c Sergey Shtylyov 2022-02-14 186 u16 nsect, lbal, lbam, lbah, error; ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 187 5d89e7cd8ab42f drivers/ata/sata_vsc.c Sergey Shtylyov 2022-02-14 188 tf->status = ata_sff_check_status(ap); 0d5ff566779f89 drivers/ata/sata_vsc.c Tejun Heo 2007-02-01 189 tf->device = readw(ioaddr->device_addr); 5d89e7cd8ab42f drivers/ata/sata_vsc.c Sergey Shtylyov 2022-02-14 190 error = readw(ioaddr->error_addr); 0d5ff566779f89 drivers/ata/sata_vsc.c Tejun Heo 2007-02-01 191 nsect = readw(ioaddr->nsect_addr); 0d5ff566779f89 drivers/ata/sata_vsc.c Tejun Heo 2007-02-01 192 lbal = readw(ioaddr->lbal_addr); 0d5ff566779f89 drivers/ata/sata_vsc.c Tejun Heo 2007-02-01 193 lbam = readw(ioaddr->lbam_addr); 0d5ff566779f89 drivers/ata/sata_vsc.c Tejun Heo 2007-02-01 194 lbah = readw(ioaddr->lbah_addr); ac19bff25b6834 drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 195 5d89e7cd8ab42f drivers/ata/sata_vsc.c Sergey Shtylyov 2022-02-14 196 tf->error = error; ac19bff25b6834 drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 197 tf->nsect = nsect; ac19bff25b6834 drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 198 tf->lbal = lbal; ac19bff25b6834 drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 199 tf->lbam = lbam; ac19bff25b6834 drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 200 tf->lbah = lbah; ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 201 ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 202 if (tf->flags & ATA_TFLAG_LBA48) { ac19bff25b6834 drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 @203 tf->hob_feature = feature >> 8; ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 204 tf->hob_nsect = nsect >> 8; ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 205 tf->hob_lbal = lbal >> 8; ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 206 tf->hob_lbam = lbam >> 8; ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 207 tf->hob_lbah = lbah >> 8; ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 208 } ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 209 } ^1da177e4c3f41 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 210 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org