From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0299C433EF for ; Wed, 16 Feb 2022 18:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234331AbiBPSdl (ORCPT ); Wed, 16 Feb 2022 13:33:41 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230474AbiBPSdk (ORCPT ); Wed, 16 Feb 2022 13:33:40 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5958F14345C; Wed, 16 Feb 2022 10:33:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BB47D616A4; Wed, 16 Feb 2022 18:33:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE3B5C340E8; Wed, 16 Feb 2022 18:33:19 +0000 (UTC) Date: Wed, 16 Feb 2022 13:33:18 -0500 From: Steven Rostedt To: Linus Torvalds Cc: Damien Le Moal , Byungchul Park , linux-ide@vger.kernel.org, Ingo Molnar , Linux Kernel Mailing List , Peter Zijlstra , Will Deacon , Thomas Gleixner , Joel Fernandes , Sasha Levin , Daniel Vetter , Chris Wilson , duyuyang@gmail.com, johannes.berg@intel.com, Tejun Heo , "Theodore Ts'o" , Matthew Wilcox , Dave Chinner , Amir Goldstein , "J. Bruce Fields" , Greg Kroah-Hartman , kernel-team@lge.com, Linux-MM , Andrew Morton , Michal Hocko , Minchan Kim , Johannes Weiner , Vladimir Davydov , sj@kernel.org, Jerome Glisse , Dennis Zhou , Christoph Lameter , Pekka Enberg , David Rientjes , Vlastimil Babka , ngupta@vflare.org, linux-block , Jens Axboe , paolo.valente@linaro.org, Josef Bacik , linux-fsdevel , Al Viro , Jan Kara , Jeff Layton , Dan Williams , Christoph Hellwig , "Darrick J. Wong" , dri-devel , Dave Airlie , rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com Subject: Re: Report in ata_scsi_port_error_handler() Message-ID: <20220216133318.204f36ac@gandalf.local.home> In-Reply-To: References: <1644984747-26706-1-git-send-email-byungchul.park@lge.com> <1644984964-28300-1-git-send-email-byungchul.park@lge.com> <1644984964-28300-3-git-send-email-byungchul.park@lge.com> <94b1cba2-0e78-bbc0-0321-8be70b2b3be2@opensource.wdc.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Wed, 16 Feb 2022 10:09:14 -0800 Linus Torvalds wrote: > Byungchul, could you fix those two issues? Some of your reports may > well be entirely valid, but the hard-to-read hex offsets and the > knowledge that at least some of them are confused about how > prepare_to_wait -> wait actually works makes the motivation to look at > the details much less.. Hi Byungchul, I'm not sure what your tool is using to attach to the kernel to analyze the events (perhaps tracepoints?). But you can have the prepare_to_wait event just flag the task is about to wait, and then attach to the schedule (sched_switch) event to denote that it actually waited. Of course have the finish_wait() clear the flag. -- Steve