From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67BCCC433F5 for ; Tue, 22 Feb 2022 08:35:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbiBVIfz (ORCPT ); Tue, 22 Feb 2022 03:35:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229870AbiBVIfy (ORCPT ); Tue, 22 Feb 2022 03:35:54 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78326159281; Tue, 22 Feb 2022 00:35:29 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 0512868AA6; Tue, 22 Feb 2022 09:35:26 +0100 (CET) Date: Tue, 22 Feb 2022 09:35:25 +0100 From: Christoph Hellwig To: Ondrej Zary Cc: Damien Le Moal , Christoph Hellwig , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pata_parport: second preview Message-ID: <20220222083525.GB5899@lst.de> References: <20220220224909.8032-1-linux@zary.sk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220220224909.8032-1-linux@zary.sk> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Sun, Feb 20, 2022 at 11:49:09PM +0100, Ondrej Zary wrote: > Protocol registration could be improved - I don't like protocols[] and > protocol numbers, devices should probably be created by protocol name. > Also the LPT port base addresses should probably be replaced by port names > (like parport0). > > The bpck driver seems to need to know if a CD drive is attached (weird) but > I doubt that I can get such info from libata. You can check adev->class == ATA_DEV_ATAPI, there's a bunch of drivers that already do that. I'll try to take a look at the actual patch once I find a bit of time.