Re: [PATCH 02/16] dept: Implement Dept(Dependency Tracker)

kernel test robot
2022-02-17T19:47:17Z

Hi Byungchul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on hnaz-mm/master linux/master linus/master v5.17-rc4]
[cannot apply to tip/locking/core next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Byungchul-Park/DEPT-Dependency-Tracker/20220217-190040
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 3624ba7b5e2acc02b01301ea5fd3534971eb9896
config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20220218/202202180059.SibYSAt1-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4d0434b0b917f4374a09f3b75cbcadf148cfa711
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Byungchul-Park/DEPT-Dependency-Tracker/20220217-190040
git checkout 4d0434b0b917f4374a09f3b75cbcadf148cfa711
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/net/ethernet/sfc/falcon/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from include/linux/delay.h:23,
from drivers/net/ethernet/sfc/falcon/falcon.c:9:
drivers/net/ethernet/sfc/falcon/falcon.c: In function 'falcon_spi_slow_wait':
>> drivers/net/ethernet/sfc/falcon/falcon.c:750:58: warning: '?:' using integer constants in boolean context [-Wint-in-bool-context]
750 | TASK_UNINTERRUPTIBLE : TASK_INTERRUPTIBLE);
include/linux/sched.h:205:21: note: in definition of macro '__set_current_state'
205 | if (state_value == TASK_RUNNING) \
| ^~~~~~~~~~~

vim +750 drivers/net/ethernet/sfc/falcon/falcon.c

4a5b504d0c582db drivers/net/sfc/falcon.c Ben Hutchings 2008-09-01 738
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 739 static int
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 740 falcon_spi_slow_wait(struct falcon_mtd_partition *part, bool uninterruptible)
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 741 {
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 742 const struct falcon_spi_device *spi = part->spi;
5a6681e22c14090 drivers/net/ethernet/sfc/falcon/falcon.c Edward Cree 2016-11-28 743 struct ef4_nic *efx = part->common.mtd.priv;
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 744 u8 status;
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 745 int rc, i;
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 746
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 747 /* Wait up to 4s for flash/EEPROM to finish a slow operation. */
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 748 for (i = 0; i < 40; i++) {
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 749 __set_current_state(uninterruptible ?
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 @750 TASK_UNINTERRUPTIBLE : TASK_INTERRUPTIBLE);
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 751 schedule_timeout(HZ / 10);
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 752 rc = falcon_spi_cmd(efx, spi, SPI_RDSR, -1, NULL,
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 753 &status, sizeof(status));
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 754 if (rc)
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 755 return rc;
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 756 if (!(status & SPI_STATUS_NRDY))
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 757 return 0;
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 758 if (signal_pending(current))
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 759 return -EINTR;
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 760 }
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 761 pr_err("%s: timed out waiting for %s\n",
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 762 part->common.name, part->common.dev_type_name);
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 763 return -ETIMEDOUT;
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 764 }
45a3fd55acc8989 drivers/net/ethernet/sfc/falcon.c Ben Hutchings 2012-11-28 765

---
0-DAY CI Kernel Test Service, Intel Corporation