From: Christoph Hellwig <hch@lst.de>
To: Ondrej Zary <linux@zary.sk>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Tim Waugh <tim@cyberelk.net>,
linux-block@vger.kernel.org, linux-parport@lists.infradead.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v0] pata_parport: add driver (PARIDE replacement)
Date: Tue, 15 Mar 2022 09:23:01 +0100 [thread overview]
Message-ID: <20220315082301.GA3502@lst.de> (raw)
In-Reply-To: <202203121221.56068.linux@zary.sk>
On Sat, Mar 12, 2022 at 12:21:55PM +0100, Ondrej Zary wrote:
> > Here, I am assuming that block/paride is the core code used by both
> > PARIDE and PATA_PARPORT. Not sure what PARPORT_PC does nor what its
> > dependency on block/paride code is.
>
> There's no common core in block/paride. The block/paride/Makefile says:
> obj-$(CONFIG_PARIDE) += paride.o
> obj-$(CONFIG_PARIDE_ATEN) += aten.o
> obj-$(CONFIG_PARIDE_...other protocol drivers
>
> So if PARIDE and all protocol drivers are disabled, nothing is compiled there.
Yeah. The pattern of unconditionally descending into a subdirectory
isn't entirely uncommon. I think this is perfectly fine here.
next prev parent reply other threads:[~2022-03-15 8:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 21:28 [PATCH v0] pata_parport: add driver (PARIDE replacement) Ondrej Zary
2022-03-10 23:59 ` Damien Le Moal
2022-03-11 18:55 ` Ondrej Zary
2022-03-12 8:09 ` Damien Le Moal
2022-03-12 11:21 ` Ondrej Zary
2022-03-15 8:23 ` Christoph Hellwig [this message]
2022-03-11 5:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315082301.GA3502@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux@zary.sk \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).