From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4867FC433F5 for ; Tue, 15 Mar 2022 08:25:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345776AbiCOI0N (ORCPT ); Tue, 15 Mar 2022 04:26:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243406AbiCOI0M (ORCPT ); Tue, 15 Mar 2022 04:26:12 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D7323981F; Tue, 15 Mar 2022 01:25:01 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 08FED68AA6; Tue, 15 Mar 2022 09:24:57 +0100 (CET) Date: Tue, 15 Mar 2022 09:24:57 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Ondrej Zary , Damien Le Moal , Christoph Hellwig , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pata_parport: add driver (PARIDE replacement) Message-ID: <20220315082457.GB3502@lst.de> References: <20220312144415.20010-1-linux@zary.sk> <202203132015.18183.linux@zary.sk> <5161ed17-5f55-e851-c2e2-5340cc62fa3b@kernel.dk> <202203142125.40532.linux@zary.sk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Mon, Mar 14, 2022 at 02:29:20PM -0600, Jens Axboe wrote: > The controller would set > > ->needs_blocking_queue_rq = true; > > or something, and we'd default to false. And if that is set, when the > blk-mq queue is created, then we'd set BLK_MQ_F_BLOCKING upon creation > if that flag is true. > > That's the block layer side. Then in libata you'd need to ensure that > you check that same setting and invoke ata_qc_issue() appropriately. > > Very top level stuff, there might be more things lurking below. But > you'll probably find them as you test this stuff... FYI, this somewhat mistitled series: https://lore.kernel.org/all/20220308003957.123312-1-michael.christie@oracle.com/ adds BLK_MQ_F_BLOCKING support to the scsi core. Doing libata should be fairly easy and can built ontop of that.