Re: [PATCH 00/21] ata: ahci: Add DWC/Baikal-T1 AHCI SATA support

Damien Le Moal
2022-03-28T20:07:24Z

On 3/24/22 09:16, Serge Semin wrote:
[...]
> After the denoted above functionality is added we can finally introduce
> the Baikal-T1 AHCI SATA controller support into the DWC AHCI SATA driver.
> The controller is based on the DWC AHCI SATA IP-core v4.10a and can work
> well with the generic DWC AHCI driver. The only peculiarity of it is
> connected with the SATA Ports reference clock source. It can be supplied
> either from the internal SoC PLL or from the chip pads. Currently we have
> to prefer selecting the signal coming from the pads if the corresponding
> clock source is specified because the link doesn't get stably established
> when the internal clock signal is activated. In addition the platform has
> trigger-based reset signals so the corresponding flag must be passed to
> the generic AHCI-resource getter.
>

I am assuming this is "v2" of your patches. Please add this version number
to your patch titles ("[PATCH v2]") and add a changelog here in the cover
letter.

> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> Cc: Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: linux-ide@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: devicetree@vger.kernel.org
>
> Serge Semin (21):
> dt-bindings: ata: sata: Extend number of SATA ports
> dt-bindings: ata: Convert AHCI-bindings to DT schema
> ata: libahci_platform: Explicitly set rc on devres_alloc failure
> ata: libahci_platform: Convert to using handy devm-ioremap methods
> ata: libahci_platform: Convert to using devm bulk clocks API
> ata: libahci_platform: Add function returning a clock-handle by id
> ata: libahci_platform: Sanity check the DT child nodes number
> ata: libahci_platform: Parse ports-implemented property in resources
> getter
> ata: libahci_platform: Introduce reset assertion/deassertion methods
> dt-bindings: ata: ahci: Add platform capability properties
> ata: libahci: Extend port-cmd flags set with port capabilities
> ata: libahci: Discard redundant force_port_map parameter
> ata: libahci: Don't read AHCI version twice in the save-config method
> ata: ahci: Convert __ahci_port_base to accepting hpriv as arguments
> ata: ahci: Introduce firmware-specific caps initialization
> dt-bindings: ata: ahci: Add DWC AHCI SATA controller DT schema
> ata: ahci: Add DWC AHCI SATA controller support
> dt-bindings: ata: ahci: Add Baikal-T1 AHCI SATA controller DT schema
> ata: ahci-dwc: Add platform-specific quirks support
> ata: ahci-dwc: Add Baikal-T1 AHCI SATA interface support
> MAINTAINERS: Add maintainers for DWC AHCI SATA driver
>
> .../devicetree/bindings/ata/ahci-common.yaml | 176 ++++++
> .../devicetree/bindings/ata/ahci-platform.txt | 79 ---
> .../bindings/ata/baikal,bt1-ahci.yaml | 132 +++++
> .../devicetree/bindings/ata/generic-ahci.yaml | 98 ++++
> .../devicetree/bindings/ata/sata-common.yaml | 7 +-
> .../bindings/ata/snps,dwc-ahci.yaml | 121 ++++
> MAINTAINERS | 9 +
> drivers/ata/Kconfig | 11 +
> drivers/ata/Makefile | 1 +
> drivers/ata/ahci.c | 4 +-
> drivers/ata/ahci.h | 21 +-
> drivers/ata/ahci_dwc.c | 525 ++++++++++++++++++
> drivers/ata/ahci_mtk.c | 2 -
> drivers/ata/ahci_platform.c | 5 -
> drivers/ata/ahci_st.c | 3 -
> drivers/ata/libahci.c | 63 ++-
> drivers/ata/libahci_platform.c | 234 +++++---
> include/linux/ahci_platform.h | 8 +-
> 18 files changed, 1321 insertions(+), 178 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/ata/ahci-common.yaml
> delete mode 100644 Documentation/devicetree/bindings/ata/ahci-platform.txt
> create mode 100644 Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml
> create mode 100644 Documentation/devicetree/bindings/ata/generic-ahci.yaml
> create mode 100644 Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml
> create mode 100644 drivers/ata/ahci_dwc.c
>

--
Damien Le Moal
Western Digital Research