From: Mario Limonciello <mario.limonciello@amd.com>
To: <mario.limonciello@amd.com>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: [PATCH] ata: Kconfig: Update SATA_LPM_POLICY default to "3"
Date: Thu, 24 Mar 2022 09:59:05 -0500 [thread overview]
Message-ID: <20220324145905.4176-1-mario.limonciello@amd.com> (raw)
SATA_LPM_POLICY is a "new" configuration item, but it was renamed from
SATA_LPM_MOBILE_POLICY in commit 4dd4d3deb502 ("ata: ahci: Rename
CONFIG_SATA_LPM_MOBILE_POLICY configuration item")
Since the configuration item was renamed it was mentioned that people
might invisibly lose their chosen defaults for it. This means it's a
good time to evaluate whether those defaults make sense still.
Historically this was set to "0" to prevent problems with power management
on very old drives. However it's been observed that almost all modern
Linux distributions either set the policy to "3" in the kernel
configuration or update it to this via userspace policy changes. Update
the policy default in the kernel to "3" to match that behavior as well.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
We at least have confirmation from:
* Ubuntu
* RHEL/CentOS/SUSE
* Arch
* Gentoo
* Debian
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index e5641e6c52ee..3ffe14057ed2 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -118,7 +118,7 @@ config SATA_AHCI
config SATA_LPM_POLICY
int "Default SATA Link Power Management policy for low power chipsets"
range 0 4
- default 0
+ default 3
depends on SATA_AHCI
help
Select the Default SATA Link Power Management (LPM) policy to use
--
2.34.1
next reply other threads:[~2022-03-24 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 14:59 Mario Limonciello [this message]
2022-03-24 15:05 ` [PATCH] ata: Kconfig: Update SATA_LPM_POLICY default to "3" Christoph Hellwig
2022-03-24 15:09 ` Limonciello, Mario
2022-03-28 0:37 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324145905.4176-1-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox