linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: linux-ide@vger.kernel.org, linux-block@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>,
	"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
	Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v5 5/7] ata: libata: Fix FUA handling in ata_build_rw_tf()
Date: Mon, 7 Nov 2022 06:50:00 +0100	[thread overview]
Message-ID: <20221107055000.GD28873@lst.de> (raw)
In-Reply-To: <20221107005021.1327692-6-damien.lemoal@opensource.wdc.com>

On Mon, Nov 07, 2022 at 09:50:19AM +0900, Damien Le Moal wrote:
> Finally, since the block layer should never issue a FUA read
> request, warn in ata_build_rw_tf() if we see such request.

Couldn't this be triggered using SG_IO passthrough with a SCSI 
WRITE* command that has the FUA bit set?

  parent reply	other threads:[~2022-11-07  5:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07  0:50 [PATCH v5 0/7] Improve libata support for FUA Damien Le Moal
2022-11-07  0:50 ` [PATCH v5 1/7] block: add a sanity check for non-write flush/fua bios Damien Le Moal
2022-11-07  5:40   ` Chaitanya Kulkarni
2022-11-07 10:23   ` Hannes Reinecke
2022-11-07  0:50 ` [PATCH v5 2/7] ata: libata: Introduce ata_ncq_supported() Damien Le Moal
2022-11-07  5:41   ` Chaitanya Kulkarni
2022-11-07  5:46   ` Christoph Hellwig
2022-11-07  0:50 ` [PATCH v5 3/7] ata: libata: Rename and cleanup ata_rwcmd_protocol() Damien Le Moal
2022-11-07  5:43   ` Chaitanya Kulkarni
2022-11-07  5:47   ` Christoph Hellwig
2022-11-07  0:50 ` [PATCH v5 4/7] ata: libata: cleanup fua support detection Damien Le Moal
2022-11-07  5:44   ` Chaitanya Kulkarni
2022-11-07  5:48   ` Christoph Hellwig
2022-11-07  0:50 ` [PATCH v5 5/7] ata: libata: Fix FUA handling in ata_build_rw_tf() Damien Le Moal
2022-11-07  5:45   ` Chaitanya Kulkarni
2022-11-07  5:50   ` Christoph Hellwig [this message]
2022-11-07 12:12     ` Damien Le Moal
2022-11-07 12:16       ` Christoph Hellwig
2022-11-07 12:32         ` Damien Le Moal
2022-11-08  5:53         ` Damien Le Moal
2022-11-07  0:50 ` [PATCH v5 6/7] ata: libata: blacklist FUA support for known buggy drives Damien Le Moal
2022-11-07  5:46   ` Chaitanya Kulkarni
2022-11-07  5:50   ` Christoph Hellwig
2022-11-07  0:50 ` [PATCH v5 7/7] ata: libata: Enable fua support by default Damien Le Moal
2022-11-07  5:47   ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221107055000.GD28873@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=hare@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).