From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CDCAC433FE for ; Mon, 7 Nov 2022 05:50:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229559AbiKGFuE (ORCPT ); Mon, 7 Nov 2022 00:50:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbiKGFuD (ORCPT ); Mon, 7 Nov 2022 00:50:03 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8B9CB7D4; Sun, 6 Nov 2022 21:50:02 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 5A92C68BFE; Mon, 7 Nov 2022 06:50:00 +0100 (CET) Date: Mon, 7 Nov 2022 06:50:00 +0100 From: Christoph Hellwig To: Damien Le Moal Cc: linux-ide@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe , "Maciej S . Szmigiero" , Hannes Reinecke , Christoph Hellwig Subject: Re: [PATCH v5 5/7] ata: libata: Fix FUA handling in ata_build_rw_tf() Message-ID: <20221107055000.GD28873@lst.de> References: <20221107005021.1327692-1-damien.lemoal@opensource.wdc.com> <20221107005021.1327692-6-damien.lemoal@opensource.wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221107005021.1327692-6-damien.lemoal@opensource.wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Mon, Nov 07, 2022 at 09:50:19AM +0900, Damien Le Moal wrote: > Finally, since the block layer should never issue a FUA read > request, warn in ata_build_rw_tf() if we see such request. Couldn't this be triggered using SG_IO passthrough with a SCSI WRITE* command that has the FUA bit set?