From: Ondrej Zary <linux@zary.sk>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Tim Waugh <tim@cyberelk.net>,
linux-block@vger.kernel.org, linux-parport@lists.infradead.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/12] pata_parport: Introduce module_pata_parport_driver macro
Date: Sun, 12 Feb 2023 19:19:26 +0100 [thread overview]
Message-ID: <202302121919.26401.linux@zary.sk> (raw)
In-Reply-To: <2e8b5e5b-6e7d-471c-74aa-1c7debebef0f@omp.ru>
On Sunday 12 February 2023 13:19:28 Sergey Shtylyov wrote:
> On 2/11/23 5:42 PM, Ondrej Zary wrote:
>
> > Introduce module_pata_parport_driver macro and use it in protocol
> > drivers to reduce boilerplate code. Remove paride_(un)register
> > compatibility defines.
> >
> > Signed-off-by: Ondrej Zary <linux@zary.sk>
> [...]
>
> > diff --git a/drivers/ata/pata_parport/bpck6.c b/drivers/ata/pata_parport/bpck6.c
> > index d897e2a28efe..3c358e66db25 100644
> > --- a/drivers/ata/pata_parport/bpck6.c
> > +++ b/drivers/ata/pata_parport/bpck6.c
> > @@ -245,23 +245,8 @@ static struct pi_protocol bpck6 = {
> > .release_proto = bpck6_release_proto,
> > };
> >
> > -static int __init bpck6_init(void)
> > -{
> > - printk(KERN_INFO "bpck6: BACKPACK Protocol Driver V"BACKPACK_VERSION"\n");
> > - printk(KERN_INFO "bpck6: Copyright 2001 by Micro Solutions, Inc., DeKalb IL. USA\n");
> > - if(verbose)
> > - printk(KERN_DEBUG "bpck6: verbose debug enabled.\n");
>
> Hm, perhaps should've been removed in a separate patch?
>
> [...]
> > diff --git a/drivers/ata/pata_parport/epat.c b/drivers/ata/pata_parport/epat.c
> > index 6ce2dee7657f..eb72bcd0c8da 100644
> > --- a/drivers/ata/pata_parport/epat.c
> > +++ b/drivers/ata/pata_parport/epat.c
> > @@ -327,12 +327,12 @@ static int __init epat_init(void)
> > #ifdef CONFIG_PARIDE_EPATC8
>
> Hm, this is now called PATA_PARPORT_EPATC8, no?
Yes, it's a bug. This compile-time option should go away completely.
> > epatc8 = 1;
>
> Seems like a dead code?
>
> > #endif
> [...]
>
> MBR, Sergey
>
--
Ondrej Zary
next prev parent reply other threads:[~2023-02-12 18:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 14:42 [PATCH 0/12] pata_parport: protocol drivers cleanups Ondrej Zary
2023-02-11 14:42 ` [PATCH 01/12] pata_parport: Remove pi_swab16 and pi_swab32 Ondrej Zary
2023-02-11 19:01 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 02/12] pata_parport: Introduce module_pata_parport_driver macro Ondrej Zary
2023-02-12 12:19 ` Sergey Shtylyov
2023-02-12 18:19 ` Ondrej Zary [this message]
2023-02-11 14:42 ` [PATCH 03/12] pata_parport: remove devtype from struct pi_adapter Ondrej Zary
2023-02-11 19:11 ` Sergey Shtylyov
2023-02-11 20:47 ` Ondrej Zary
2023-02-12 12:17 ` Damien Le Moal
2023-02-11 14:42 ` [PATCH 04/12] pata_parport: remove device " Ondrej Zary
2023-02-12 17:36 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 05/12] pata_parport: remove typedef struct PIA Ondrej Zary
2023-02-13 20:08 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 06/12] pata_parport: remove verbose parameter from log_adapter() Ondrej Zary
2023-02-11 20:43 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 07/12] pata_parport: remove scratch " Ondrej Zary
2023-02-12 17:14 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 08/12] pata_parport: use dev_* and print_hex_* instead of printk Ondrej Zary
2023-02-14 20:55 ` Sergei Shtylyov
2023-02-11 14:42 ` [PATCH 09/12] pata_parport: remove verbose parameter from test_proto() Ondrej Zary
2023-02-11 19:56 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 10/12] pata_parport: remove scratch " Ondrej Zary
2023-02-12 17:47 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 11/12] pata_parport: remove obsolete changelogs Ondrej Zary
2023-02-13 20:42 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 12/12] pata_parport: move pata_parport.h to drivers/ata/pata_parport Ondrej Zary
2023-02-13 20:51 ` Sergey Shtylyov
2023-02-11 20:59 ` [PATCH 0/12] pata_parport: protocol drivers cleanups Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302121919.26401.linux@zary.sk \
--to=linux@zary.sk \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=s.shtylyov@omp.ru \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).