From: Bjorn Helgaas <helgaas@kernel.org>
To: Patrick McLean <chutzpah@gentoo.org>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] gpu: Move ASPEED vendor ID definition to pci_ids.h
Date: Tue, 18 Apr 2023 16:17:14 -0500 [thread overview]
Message-ID: <20230418211714.GA161849@bhelgaas> (raw)
In-Reply-To: <20230418211403.GA160979@bhelgaas>
On Tue, Apr 18, 2023 at 04:14:03PM -0500, Bjorn Helgaas wrote:
> Most subject lines for pci_ids.h look like this:
>
> PCI: Add ASPEED vendor ID
>
> On Mon, Apr 17, 2023 at 06:17:19PM -0700, Patrick McLean wrote:
> > Currently the ASPEED PCI vendor ID is defined in drivers/gpu/drm/ast/ast_drv.c,
> > move that to include/linux/pci_ids.h with all the rest of the PCI vendor ID
> > definitions. Rename the definition to follow the format that the other
> > definitions follow.
> >
> > Signed-off-by: Patrick McLean <chutzpah@gentoo.org>
>
> Given the subject line and file placement (below) updates,
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Oh, at the same time, would you mind rewrapping at least this commit
log so it fits in 75 columns to "git log" doesn't overflow an 80
column terminal?
Bjorn
next prev parent reply other threads:[~2023-04-18 21:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 1:17 Apply ATI NCQ horkage to ASPEED as well Patrick McLean
2023-04-18 1:17 ` [PATCH 1/2] gpu: Move ASPEED vendor ID definition to pci_ids.h Patrick McLean
2023-04-18 8:35 ` Daniel Vetter
2023-04-18 8:48 ` Sergei Shtylyov
2023-04-18 21:14 ` Bjorn Helgaas
2023-04-18 21:17 ` Bjorn Helgaas [this message]
2023-04-18 1:17 ` [PATCH 2/2] ata: libata-core: Apply ATI NCQ horkage to ASPEED as well Patrick McLean
2023-04-18 5:24 ` Christoph Hellwig
2023-04-18 8:00 ` Damien Le Moal
2023-04-18 8:42 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418211714.GA161849@bhelgaas \
--to=helgaas@kernel.org \
--cc=airlied@redhat.com \
--cc=bhelgaas@google.com \
--cc=chutzpah@gentoo.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox