* [PATCH] [v2] ata: pata_ns87415: mark ns87560_tf_read static
@ 2023-07-26 20:33 Arnd Bergmann
2023-07-26 23:45 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-07-26 20:33 UTC (permalink / raw)
To: Damien Le Moal
Cc: Arnd Bergmann, Sergey Shtylyov, Jon Hunter, Bart Van Assche,
linux-ide, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The global function triggers a warning because of the missing prototype
drivers/ata/pata_ns87415.c:263:6: warning: no previous prototype for 'ns87560_tf_read' [-Wmissing-prototypes]
263 | void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
There are no other references to this, so just make it static.
Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: fix changelog text
---
drivers/ata/pata_ns87415.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_ns87415.c b/drivers/ata/pata_ns87415.c
index d60e1f69d7b02..c697219a61a2d 100644
--- a/drivers/ata/pata_ns87415.c
+++ b/drivers/ata/pata_ns87415.c
@@ -260,7 +260,7 @@ static u8 ns87560_check_status(struct ata_port *ap)
* LOCKING:
* Inherited from caller.
*/
-void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
+static void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
{
struct ata_ioports *ioaddr = &ap->ioaddr;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [v2] ata: pata_ns87415: mark ns87560_tf_read static
2023-07-26 20:33 [PATCH] [v2] ata: pata_ns87415: mark ns87560_tf_read static Arnd Bergmann
@ 2023-07-26 23:45 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2023-07-26 23:45 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Arnd Bergmann, Sergey Shtylyov, Jon Hunter, Bart Van Assche,
linux-ide, linux-kernel
On 7/27/23 05:33, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The global function triggers a warning because of the missing prototype
>
> drivers/ata/pata_ns87415.c:263:6: warning: no previous prototype for 'ns87560_tf_read' [-Wmissing-prototypes]
> 263 | void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
>
> There are no other references to this, so just make it static.
>
> Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to for-6.5-fixes. Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-26 23:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 20:33 [PATCH] [v2] ata: pata_ns87415: mark ns87560_tf_read static Arnd Bergmann
2023-07-26 23:45 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox