From: Michael Schmitz <schmitzmic@gmail.com>
To: dlemoal@kernel.org, linux-ide@vger.kernel.org,
linux-m68k@vger.kernel.org
Cc: will@sowerbutts.com, rz@linux-m68k.org, geert@linux-m68k.org,
Michael Schmitz <schmitzmic@gmail.com>
Subject: [PATCH v2 3/3] m68k/atari: change Falcon IDE platform device to id 0
Date: Fri, 18 Aug 2023 19:14:05 +1200 [thread overview]
Message-ID: <20230818071405.28581-4-schmitzmic@gmail.com> (raw)
In-Reply-To: <20230818071405.28581-1-schmitzmic@gmail.com>
The pata_falcon data byte swapping patch relies on pdev->id
being 0 or 1. Q40 uses these IDs, but Atari used -1. Change
pdev->id to 0 for Atari Falcon IDE platform device so
selection of drive to byte-swap through pata_falcon.data_swab
can be used on Falcon as well.
Tested on ARAnyM so far.
Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
---
arch/m68k/atari/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/m68k/atari/config.c b/arch/m68k/atari/config.c
index 38a7c0578105..e3e437cd0f84 100644
--- a/arch/m68k/atari/config.c
+++ b/arch/m68k/atari/config.c
@@ -925,7 +925,7 @@ int __init atari_platform_init(void)
#endif
if (ATARIHW_PRESENT(IDE)) {
- pdev = platform_device_register_simple("atari-falcon-ide", -1,
+ pdev = platform_device_register_simple("atari-falcon-ide", 0,
atari_falconide_rsrc, ARRAY_SIZE(atari_falconide_rsrc));
if (IS_ERR(pdev))
rv = PTR_ERR(pdev);
--
2.17.1
next prev parent reply other threads:[~2023-08-18 7:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 7:14 [PATCH v2 0/3] Q40 IDE fixes Michael Schmitz
2023-08-18 7:14 ` [PATCH v2 1/3] ata: pata_falcon: fix IO base selection for Q40 Michael Schmitz
2023-08-18 7:52 ` Finn Thain
2023-08-18 20:42 ` Michael Schmitz
2023-08-18 7:14 ` [PATCH v2 2/3] ata: pata_falcon: add data_swab option to byte-swap disk data Michael Schmitz
2023-08-18 7:43 ` Finn Thain
2023-08-18 14:39 ` Geert Uytterhoeven
2023-08-18 23:51 ` Finn Thain
2023-08-18 20:44 ` Michael Schmitz
2023-08-18 7:14 ` Michael Schmitz [this message]
2023-08-18 14:44 ` [PATCH v2 3/3] m68k/atari: change Falcon IDE platform device to id 0 Geert Uytterhoeven
2023-08-18 20:40 ` Michael Schmitz
2023-08-19 0:07 ` Finn Thain
2023-08-19 0:40 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818071405.28581-4-schmitzmic@gmail.com \
--to=schmitzmic@gmail.com \
--cc=dlemoal@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=rz@linux-m68k.org \
--cc=will@sowerbutts.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox