From: Damien Le Moal <dlemoal@kernel.org>
To: linux-ide@vger.kernel.org
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Paul Ausbeck <paula@soe.ucsc.edu>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Joe Breuer <linux-kernel@jmbreuer.net>
Subject: [PATCH 15/19] ata: libata-core: Do not resume ports that have been runtime suspended
Date: Mon, 11 Sep 2023 13:02:13 +0900 [thread overview]
Message-ID: <20230911040217.253905-16-dlemoal@kernel.org> (raw)
In-Reply-To: <20230911040217.253905-1-dlemoal@kernel.org>
The scsi disk driver does not resume disks that have been runtime
suspended by the user. To be consistent with this behavior, do the same
for ata ports and skip the PM request in ata_port_pm_resume() if the
port was already runtime suspended. With this change, it is no longer
necessary to for the PM state of the port to ACTIVE as the PM core code
will take care of that when handling runtime resume.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
drivers/ata/libata-core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index c4a32abc2e29..26e94edf5103 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5234,10 +5234,8 @@ static void ata_port_resume(struct ata_port *ap, pm_message_t mesg,
static int ata_port_pm_resume(struct device *dev)
{
- ata_port_resume(to_ata_port(dev), PMSG_RESUME, true);
- pm_runtime_disable(dev);
- pm_runtime_set_active(dev);
- pm_runtime_enable(dev);
+ if (!pm_runtime_suspended(dev))
+ ata_port_resume(to_ata_port(dev), PMSG_RESUME, true);
return 0;
}
--
2.41.0
next prev parent reply other threads:[~2023-09-11 4:03 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 4:01 [PATCH 00/19] Fix libata suspend/resume handling and code cleanup Damien Le Moal
2023-09-11 4:01 ` [PATCH 01/19] ata: libata-core: Fix ata_port_request_pm() locking Damien Le Moal
2023-09-11 6:34 ` Hannes Reinecke
2023-09-13 1:41 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 02/19] ata: libata-core: Fix port and device removal Damien Le Moal
2023-09-11 6:37 ` Hannes Reinecke
2023-09-11 6:44 ` Damien Le Moal
2023-09-11 7:07 ` Hannes Reinecke
2023-09-13 1:43 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 03/19] ata: libata-scsi: link ata port and scsi device Damien Le Moal
2023-09-11 6:41 ` Hannes Reinecke
2023-09-11 6:48 ` Damien Le Moal
2023-09-11 7:07 ` Hannes Reinecke
2023-09-11 10:38 ` John Garry
2023-09-11 11:48 ` Damien Le Moal
2023-09-11 15:15 ` John Garry
2023-09-12 6:13 ` Damien Le Moal
2023-09-12 8:49 ` John Garry
2023-09-12 9:00 ` Damien Le Moal
2023-09-12 9:19 ` John Garry
2023-09-13 1:43 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 04/19] ata: libata-scsi: Disable scsi device manage_start_stop Damien Le Moal
2023-09-11 6:46 ` Hannes Reinecke
2023-09-11 6:59 ` Damien Le Moal
2023-09-11 7:09 ` Hannes Reinecke
2023-09-14 16:37 ` Phillip Susi
2023-09-13 1:44 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 05/19] ata: libata-scsi: Fix delayed scsi_rescan_device() execution Damien Le Moal
2023-09-11 6:47 ` Hannes Reinecke
2023-09-13 1:44 ` Chia-Lin Kao (AceLan)
2023-09-14 17:25 ` Bart Van Assche
2023-09-14 22:05 ` Damien Le Moal
2023-09-11 4:02 ` [PATCH 06/19] ata: libata-core: Do not register PM operations for SAS ports Damien Le Moal
2023-09-11 6:50 ` Hannes Reinecke
2023-09-13 1:44 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 07/19] scsi: sd: Do not issue commands to suspended disks on remove Damien Le Moal
2023-09-11 6:51 ` Hannes Reinecke
2023-09-13 1:45 ` Chia-Lin Kao (AceLan)
2023-09-13 20:50 ` Bart Van Assche
2023-09-14 0:29 ` Damien Le Moal
2023-09-14 14:39 ` Bart Van Assche
2023-09-11 4:02 ` [PATCH 08/19] scsi: Remove scsi device no_start_on_resume flag Damien Le Moal
2023-09-11 6:52 ` Hannes Reinecke
2023-09-13 1:45 ` Chia-Lin Kao (AceLan)
2023-09-14 17:29 ` Bart Van Assche
2023-09-11 4:02 ` [PATCH 09/19] ata: libata-scsi: Cleanup ata_scsi_start_stop_xlat() Damien Le Moal
2023-09-11 6:57 ` Hannes Reinecke
2023-09-13 1:46 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 10/19] ata: libata-core: Synchronize ata_port_detach() with hotplug Damien Le Moal
2023-09-11 6:58 ` Hannes Reinecke
2023-09-13 1:46 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 11/19] ata: libata-core: Detach a port devices on shutdown Damien Le Moal
2023-09-11 6:59 ` Hannes Reinecke
2023-09-13 1:46 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 12/19] ata: libata-core: Remove ata_port_suspend_async() Damien Le Moal
2023-09-11 7:00 ` Hannes Reinecke
2023-09-13 1:47 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 13/19] ata: libata-core: Remove ata_port_resume_async() Damien Le Moal
2023-09-11 7:00 ` Hannes Reinecke
2023-09-13 1:47 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 14/19] ata: libata-core: skip poweroff for devices that are runtime suspended Damien Le Moal
2023-09-11 7:01 ` Hannes Reinecke
2023-09-13 1:48 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` Damien Le Moal [this message]
2023-09-11 7:01 ` [PATCH 15/19] ata: libata-core: Do not resume ports that have been " Hannes Reinecke
2023-09-13 1:48 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 16/19] ata: libata-sata: Improve ata_sas_slave_configure() Damien Le Moal
2023-09-11 7:02 ` Hannes Reinecke
2023-09-13 1:48 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 17/19] ata: libata-eh: Improve reset error messages Damien Le Moal
2023-09-11 7:03 ` Hannes Reinecke
2023-09-11 10:03 ` John Garry
2023-09-13 1:49 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 18/19] ata: libata-eh: Reduce "disable device" message verbosity Damien Le Moal
2023-09-11 7:05 ` Hannes Reinecke
2023-09-11 10:14 ` Sergei Shtylyov
2023-09-13 1:49 ` Chia-Lin Kao (AceLan)
2023-09-11 4:02 ` [PATCH 19/19] ata: libata: Cleanup inline DMA helper functions Damien Le Moal
2023-09-11 7:06 ` Hannes Reinecke
2023-09-13 1:49 ` Chia-Lin Kao (AceLan)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911040217.253905-16-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@jmbreuer.net \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=paula@soe.ucsc.edu \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox