From: Damien Le Moal <dlemoal@kernel.org>
To: linux-ide@vger.kernel.org
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Paul Ausbeck <paula@soe.ucsc.edu>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Joe Breuer <linux-kernel@jmbreuer.net>
Subject: [PATCH v2 18/21] ata: libata-sata: Improve ata_sas_slave_configure()
Date: Tue, 12 Sep 2023 09:56:52 +0900 [thread overview]
Message-ID: <20230912005655.368075-19-dlemoal@kernel.org> (raw)
In-Reply-To: <20230912005655.368075-1-dlemoal@kernel.org>
Change ata_sas_slave_configure() to return the return value of
ata_scsi_dev_config() to ensure that any error from that function is
propagated to libsas.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
drivers/ata/libata-sata.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
index 5d31c08be013..0748e9ea4f5f 100644
--- a/drivers/ata/libata-sata.c
+++ b/drivers/ata/libata-sata.c
@@ -1169,8 +1169,8 @@ EXPORT_SYMBOL_GPL(ata_sas_tport_delete);
int ata_sas_slave_configure(struct scsi_device *sdev, struct ata_port *ap)
{
ata_scsi_sdev_config(sdev);
- ata_scsi_dev_config(sdev, ap->link.device);
- return 0;
+
+ return ata_scsi_dev_config(sdev, ap->link.device);
}
EXPORT_SYMBOL_GPL(ata_sas_slave_configure);
--
2.41.0
next prev parent reply other threads:[~2023-09-12 3:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 0:56 [PATCH v2 00/21] Fix libata suspend/resume handling and code cleanup Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 01/21] ata: libata-core: Fix ata_port_request_pm() locking Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 02/21] ata: libata-core: Fix port and device removal Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 03/21] ata: libata-scsi: link ata port and scsi device Damien Le Moal
2023-09-13 10:25 ` Geert Uytterhoeven
2023-09-14 7:08 ` Geert Uytterhoeven
2023-09-14 7:18 ` Damien Le Moal
2023-09-14 13:18 ` Damien Le Moal
2023-09-14 13:43 ` Geert Uytterhoeven
2023-09-12 0:56 ` [PATCH v2 04/21] ata: libata-scsi: Disable scsi device manage_start_stop Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 05/21] ata: libata-scsi: Fix delayed scsi_rescan_device() execution Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 06/21] ata: libata-core: Do not register PM operations for SAS ports Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 07/21] scsi: sd: Do not issue commands to suspended disks on remove Damien Le Moal
2023-09-14 14:48 ` Bart Van Assche
2023-09-14 22:06 ` Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 08/21] ata: libata-core: Fix compilation warning in ata_dev_config_ncq() Damien Le Moal
2023-09-12 6:14 ` Hannes Reinecke
2023-09-12 0:56 ` [PATCH v2 09/21] ata: libata-eh: Fix compilation warning in ata_eh_link_report() Damien Le Moal
2023-09-12 6:14 ` Hannes Reinecke
2023-09-12 0:56 ` [PATCH v2 10/21] scsi: Remove scsi device no_start_on_resume flag Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 11/21] ata: libata-scsi: Cleanup ata_scsi_start_stop_xlat() Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 12/21] ata: libata-core: Synchronize ata_port_detach() with hotplug Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 13/21] ata: libata-core: Detach a port devices on shutdown Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 14/21] ata: libata-core: Remove ata_port_suspend_async() Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 15/21] ata: libata-core: Remove ata_port_resume_async() Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 16/21] ata: libata-core: skip poweroff for devices that are runtime suspended Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 17/21] ata: libata-core: Do not resume ports that have been " Damien Le Moal
2023-09-12 0:56 ` Damien Le Moal [this message]
2023-09-12 7:43 ` [PATCH v2 18/21] ata: libata-sata: Improve ata_sas_slave_configure() John Garry
2023-09-12 7:52 ` Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 19/21] ata: libata-eh: Improve reset error messages Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 20/21] ata: libata-eh: Reduce "disable device" message verbosity Damien Le Moal
2023-09-12 0:56 ` [PATCH v2 21/21] ata: libata: Cleanup inline DMA helper functions Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912005655.368075-19-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@jmbreuer.net \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=paula@soe.ucsc.edu \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox