From: Damien Le Moal <dlemoal@kernel.org>
To: linux-ide@vger.kernel.org
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Paul Ausbeck <paula@soe.ucsc.edu>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Joe Breuer <linux-kernel@jmbreuer.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Chia-Lin Kao <acelan.kao@canonical.com>
Subject: [PATCH v7 19/23] ata: libata-core: Do not resume runtime suspended ports
Date: Tue, 26 Sep 2023 17:15:03 +0900 [thread overview]
Message-ID: <20230926081507.69346-20-dlemoal@kernel.org> (raw)
In-Reply-To: <20230926081507.69346-1-dlemoal@kernel.org>
The scsi disk driver does not resume disks that have been runtime
suspended by the user. To be consistent with this behavior, do the same
for ata ports and skip the PM request in ata_port_pm_resume() if the
port was already runtime suspended. With this change, it is no longer
necessary to force the PM state of the port to ACTIVE as the PM core
code will take care of that when handling runtime resume.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
drivers/ata/libata-core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index df6ed386e6fc..58f03031a259 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5230,10 +5230,8 @@ static void ata_port_resume(struct ata_port *ap, pm_message_t mesg,
static int ata_port_pm_resume(struct device *dev)
{
- ata_port_resume(to_ata_port(dev), PMSG_RESUME, true);
- pm_runtime_disable(dev);
- pm_runtime_set_active(dev);
- pm_runtime_enable(dev);
+ if (!pm_runtime_suspended(dev))
+ ata_port_resume(to_ata_port(dev), PMSG_RESUME, true);
return 0;
}
--
2.41.0
next prev parent reply other threads:[~2023-09-26 8:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 8:14 [PATCH v7 00/23] Fix libata suspend/resume handling and code cleanup Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 01/23] ata: libata-core: Fix ata_port_request_pm() locking Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 02/23] ata: libata-core: Fix port and device removal Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 03/23] ata: libata-scsi: link ata port and scsi device Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 04/23] scsi: sd: Differentiate system and runtime start/stop management Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 05/23] ata: libata-scsi: Disable scsi device manage_system_start_stop Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 06/23] scsi: Do not attempt to rescan suspended devices Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 07/23] ata: libata-scsi: Fix delayed scsi_rescan_device() execution Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 08/23] ata: libata-core: Do not register PM operations for SAS ports Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 09/23] scsi: sd: Do not issue commands to suspended disks on shutdown Damien Le Moal
2023-09-27 7:46 ` Hannes Reinecke
2023-09-27 14:55 ` Bart Van Assche
2023-09-27 15:52 ` Damien Le Moal
2023-09-27 16:29 ` Bart Van Assche
2023-09-26 8:14 ` [PATCH v7 10/23] ata: libata-core: Fix compilation warning in ata_dev_config_ncq() Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 11/23] ata: libata-eh: Fix compilation warning in ata_eh_link_report() Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 12/23] scsi: Remove scsi device no_start_on_resume flag Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 13/23] ata: libata-scsi: Cleanup ata_scsi_start_stop_xlat() Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 14/23] ata: libata-core: Synchronize ata_port_detach() with hotplug Damien Le Moal
2023-09-26 8:14 ` [PATCH v7 15/23] ata: libata-core: Detach a port devices on shutdown Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 16/23] ata: libata-core: Remove ata_port_suspend_async() Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 17/23] ata: libata-core: Remove ata_port_resume_async() Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 18/23] ata: libata-core: Do not poweroff runtime suspended ports Damien Le Moal
2023-09-26 8:15 ` Damien Le Moal [this message]
2023-09-26 8:15 ` [PATCH v7 20/23] ata: libata-sata: Improve ata_sas_slave_configure() Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 21/23] ata: libata-eh: Improve reset error messages Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 22/23] ata: libata-eh: Reduce "disable device" message verbosity Damien Le Moal
2023-09-26 8:15 ` [PATCH v7 23/23] ata: libata: Cleanup inline DMA helper functions Damien Le Moal
2023-09-28 12:26 ` [PATCH v7 00/23] Fix libata suspend/resume handling and code cleanup Geert Uytterhoeven
2023-09-28 12:39 ` Damien Le Moal
2023-09-29 13:37 ` Damien Le Moal
2023-09-29 13:56 ` Geert Uytterhoeven
2023-09-29 14:29 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926081507.69346-20-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=acelan.kao@canonical.com \
--cc=geert@linux-m68k.org \
--cc=john.g.garry@oracle.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@jmbreuer.net \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=paula@soe.ucsc.edu \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox