From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: Werner Fischer <devlists@wefi.net>,
Daniel Drake <drake@endlessos.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jian-Hong Pan <jhp@endlessos.org>,
Dieter Mummenschanz <dmummenschanz@web.de>,
linux-ide@vger.kernel.org
Subject: [PATCH 2/5] ata: ahci: a hotplug capable port is an external port
Date: Thu, 1 Feb 2024 17:14:59 +0100 [thread overview]
Message-ID: <20240201161507.1147521-3-cassel@kernel.org> (raw)
In-Reply-To: <20240201161507.1147521-1-cassel@kernel.org>
A hotplug capable port is an external port, so mark it as such.
We even say this ourselves in libata-scsi.c:
/* set scsi removable (RMB) bit per ata bit, or if the
* AHCI port says it's external (Hotplug-capable, eSATA).
*/
This also matches the terminology used in AHCI 1.3.1
(the keyword to search for is "externally accessible").
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/ata/ahci.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 157ab88bdf75..8c8403bae36f 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1649,7 +1649,8 @@ static void ahci_mark_external_port(struct ata_port *ap)
u32 tmp;
tmp = readl(port_mmio + PORT_CMD);
- if ((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS))
+ if (((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS)) ||
+ (tmp & PORT_CMD_HPCP))
ap->pflags |= ATA_PFLAG_EXTERNAL;
}
@@ -1945,7 +1946,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (ap->flags & ATA_FLAG_EM)
ap->em_message_type = hpriv->em_msg_type;
- /* mark esata ports */
+ /* mark external ports (hotplug-capable, eSATA) */
ahci_mark_external_port(ap);
ahci_update_initial_lpm_policy(ap, hpriv);
--
2.43.0
next prev parent reply other threads:[~2024-02-01 16:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 16:14 [PATCH 0/5] drop low power policy board type Niklas Cassel
2024-02-01 16:14 ` [PATCH 1/5] ata: ahci: move marking of external port earlier Niklas Cassel
2024-02-02 1:52 ` Damien Le Moal
2024-02-01 16:14 ` Niklas Cassel [this message]
2024-02-02 1:54 ` [PATCH 2/5] ata: ahci: a hotplug capable port is an external port Damien Le Moal
2024-02-01 16:15 ` [PATCH 3/5] ata: ahci: drop hpriv param from ahci_update_initial_lpm_policy() Niklas Cassel
2024-02-02 1:57 ` Damien Le Moal
2024-02-01 16:15 ` [PATCH 4/5] ata: ahci: do not enable LPM on external ports Niklas Cassel
2024-02-02 2:09 ` Damien Le Moal
2024-02-01 16:15 ` [PATCH 5/5] ata: ahci: Drop low power policy board type Niklas Cassel
2024-02-02 2:12 ` Damien Le Moal
2024-02-02 2:13 ` [PATCH 0/5] drop " Damien Le Moal
2024-02-02 13:13 ` Werner Fischer
2024-02-02 15:12 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201161507.1147521-3-cassel@kernel.org \
--to=cassel@kernel.org \
--cc=devlists@wefi.net \
--cc=dlemoal@kernel.org \
--cc=dmummenschanz@web.de \
--cc=drake@endlessos.org \
--cc=jhp@endlessos.org \
--cc=linux-ide@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox