From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: linux-scsi@vger.kernel.org, John Garry <john.g.garry@oracle.com>,
Jason Yan <yanaijie@huawei.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Hannes Reinecke <hare@suse.de>,
linux-ide@vger.kernel.org
Subject: [PATCH v3 4/9] ata: libata-sata: Remove superfluous assignment in ata_sas_port_alloc()
Date: Tue, 2 Jul 2024 18:08:00 +0200 [thread overview]
Message-ID: <20240702160756.596955-15-cassel@kernel.org> (raw)
In-Reply-To: <20240702160756.596955-11-cassel@kernel.org>
ata_sas_port_alloc() calls ata_port_alloc() which already assigns ap->lock
so there is no need for ata_sas_port_alloc() to assign it again.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/ata/libata-sata.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
index e7991595bfe5..1a36a5d1d7bc 100644
--- a/drivers/ata/libata-sata.c
+++ b/drivers/ata/libata-sata.c
@@ -1228,7 +1228,6 @@ struct ata_port *ata_sas_port_alloc(struct ata_host *host,
return NULL;
ap->port_no = 0;
- ap->lock = &host->lock;
ap->pio_mask = port_info->pio_mask;
ap->mwdma_mask = port_info->mwdma_mask;
ap->udma_mask = port_info->udma_mask;
--
2.45.2
next prev parent reply other threads:[~2024-07-02 16:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 16:07 [PATCH v3 0/9] ata,libsas: Assign the unique id used for printing earlier Niklas Cassel
2024-07-02 16:07 ` [PATCH v3 1/9] ata,scsi: Remove useless wrappers ata_sas_tport_{add,delete}() Niklas Cassel
2024-07-03 10:06 ` John Garry
2024-07-02 16:07 ` [PATCH v3 2/9] ata: libata: Remove unused function declaration for ata_scsi_detect() Niklas Cassel
2024-07-02 16:07 ` [PATCH v3 3/9] ata: libata-core: Remove support for decreasing the number of ports Niklas Cassel
2024-07-02 16:08 ` Niklas Cassel [this message]
2024-07-02 16:08 ` [PATCH v3 5/9] ata: libata-core: Remove local_port_no struct member Niklas Cassel
2024-07-02 16:08 ` [PATCH v3 6/9] ata: libata: Assign print_id at port allocation time Niklas Cassel
2024-07-02 16:08 ` [PATCH v3 7/9] ata: libata-core: Reuse available ata_port print_ids Niklas Cassel
2024-07-02 16:08 ` [PATCH v3 8/9] ata,scsi: Remove useless ata_sas_port_alloc() wrapper Niklas Cassel
2024-07-03 10:20 ` John Garry
2024-07-03 18:42 ` Niklas Cassel
2024-07-02 16:08 ` [PATCH v3 9/9] ata: ahci: Add debug print for external port Niklas Cassel
2024-07-03 8:07 ` [PATCH v3 0/9] ata,libsas: Assign the unique id used for printing earlier Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702160756.596955-15-cassel@kernel.org \
--to=cassel@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).