linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: linux-scsi@vger.kernel.org, John Garry <john.g.garry@oracle.com>,
	Jason Yan <yanaijie@huawei.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Hannes Reinecke <hare@suse.de>,
	linux-ide@vger.kernel.org
Subject: [PATCH v3 9/9] ata: ahci: Add debug print for external port
Date: Tue,  2 Jul 2024 18:08:05 +0200	[thread overview]
Message-ID: <20240702160756.596955-20-cassel@kernel.org> (raw)
In-Reply-To: <20240702160756.596955-11-cassel@kernel.org>

Add a debug print that tells us if LPM is not getting enabled because the
port is external.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 drivers/ata/ahci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index fc6fd583faf8..a05c17249448 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1732,8 +1732,10 @@ static void ahci_update_initial_lpm_policy(struct ata_port *ap)
 	 * Management Interaction in AHCI 1.3.1. Therefore, do not enable
 	 * LPM if the port advertises itself as an external port.
 	 */
-	if (ap->pflags & ATA_PFLAG_EXTERNAL)
+	if (ap->pflags & ATA_PFLAG_EXTERNAL) {
+		ata_port_dbg(ap, "external port, not enabling LPM\n");
 		return;
+	}
 
 	/* If no LPM states are supported by the HBA, do not bother with LPM */
 	if ((ap->host->flags & ATA_HOST_NO_PART) &&
-- 
2.45.2


  parent reply	other threads:[~2024-07-02 16:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 16:07 [PATCH v3 0/9] ata,libsas: Assign the unique id used for printing earlier Niklas Cassel
2024-07-02 16:07 ` [PATCH v3 1/9] ata,scsi: Remove useless wrappers ata_sas_tport_{add,delete}() Niklas Cassel
2024-07-03 10:06   ` John Garry
2024-07-02 16:07 ` [PATCH v3 2/9] ata: libata: Remove unused function declaration for ata_scsi_detect() Niklas Cassel
2024-07-02 16:07 ` [PATCH v3 3/9] ata: libata-core: Remove support for decreasing the number of ports Niklas Cassel
2024-07-02 16:08 ` [PATCH v3 4/9] ata: libata-sata: Remove superfluous assignment in ata_sas_port_alloc() Niklas Cassel
2024-07-02 16:08 ` [PATCH v3 5/9] ata: libata-core: Remove local_port_no struct member Niklas Cassel
2024-07-02 16:08 ` [PATCH v3 6/9] ata: libata: Assign print_id at port allocation time Niklas Cassel
2024-07-02 16:08 ` [PATCH v3 7/9] ata: libata-core: Reuse available ata_port print_ids Niklas Cassel
2024-07-02 16:08 ` [PATCH v3 8/9] ata,scsi: Remove useless ata_sas_port_alloc() wrapper Niklas Cassel
2024-07-03 10:20   ` John Garry
2024-07-03 18:42     ` Niklas Cassel
2024-07-02 16:08 ` Niklas Cassel [this message]
2024-07-03  8:07 ` [PATCH v3 0/9] ata,libsas: Assign the unique id used for printing earlier Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240702160756.596955-20-cassel@kernel.org \
    --to=cassel@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dlemoal@kernel.org \
    --cc=hare@suse.de \
    --cc=john.g.garry@oracle.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).