From: Christoph Hellwig <hch@lst.de>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: axboe@kernel.dk, Niklas Cassel <cassel@kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 04/15] block: add an API to atomically update queue limits
Date: Mon, 29 Jul 2024 16:35:19 +0200 [thread overview]
Message-ID: <20240729143519.GA28235@lst.de> (raw)
In-Reply-To: <2011786.tdWV9SEqCh@shift>
[switching Cc lists to be more relevant]
Hi Christian,
this is another case where the block layer previously warned about
somethign that it enforces now. Switch the dma_boundary in
sata_dwc_sht to 16k (patch below) will "fix" this, but it directly
contradicts the comment next to that field.
---
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index 52f5168e4db542..4c182694ba51d1 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -1089,8 +1089,10 @@ static const struct scsi_host_template sata_dwc_sht = {
* boundary. If the block spans such a FIS boundary, there is a chance
* that a DMA burst will cross that boundary -- this results in an
* error in the host controller.
+ *
+ * XXX
*/
- .dma_boundary = 0x1fff /* ATA_DMA_BOUNDARY */,
+ .dma_boundary = SZ_16K - 1,
};
static struct ata_port_operations sata_dwc_ops = {
parent reply other threads:[~2024-07-29 14:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <2011786.tdWV9SEqCh@shift>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729143519.GA28235@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cassel@kernel.org \
--cc=chunkeey@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).