From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: Hannes Reinecke <hare@suse.de>,
Xingui Yang <yangxingui@huawei.com>,
Yu Kuai <yukuai1@huaweicloud.com>,
linux-ide@vger.kernel.org
Subject: [PATCH 0/2] Issue non-NCQ command via EH when NCQ commands in-flight
Date: Thu, 31 Oct 2024 15:07:31 +0100 [thread overview]
Message-ID: <20241031140731.224589-4-cassel@kernel.org> (raw)
Hello all,
There is a problem when an application is continuously submitting NCQ
commands (e.g. fio with a queue depth greater than 1), this can completely
starve out another application that is sending a non-NCQ command (because
the non-NCQ command will be deferred forever).
Xingui Yang reported this problem here:
https://lore.kernel.org/linux-block/eef1e927-c9b2-c61d-7f48-92e65d8b0418@huawei.com/
This series addresses the reported problem.
Please test!
Kind regards,
Niklas
Niklas Cassel (2):
ata: libata: Introduce new helper ata_qc_complete_success()
ata: libata: Issue non-NCQ command via EH when NCQ commands in-flight
drivers/ata/libata-core.c | 274 ++++++++++++++++++++++++++++++--------
drivers/ata/libata-eh.c | 60 ++++++++-
drivers/ata/libata-scsi.c | 16 ++-
drivers/ata/libata.h | 1 +
include/linux/libata.h | 8 +-
5 files changed, 297 insertions(+), 62 deletions(-)
--
2.47.0
next reply other threads:[~2024-10-31 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 14:07 Niklas Cassel [this message]
2024-10-31 14:07 ` [PATCH 1/2] ata: libata: Introduce new helper ata_qc_complete_success() Niklas Cassel
2024-11-05 7:31 ` Hannes Reinecke
2024-10-31 14:07 ` [PATCH 2/2] ata: libata: Issue non-NCQ command via EH when NCQ commands in-flight Niklas Cassel
2024-11-04 4:01 ` yangxingui
2024-11-05 9:33 ` Niklas Cassel
2024-11-05 7:33 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031140731.224589-4-cassel@kernel.org \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=yangxingui@huawei.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).