From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/4] block: simplify tag allocation policy selection
Date: Mon, 6 Jan 2025 09:55:54 +0100 [thread overview]
Message-ID: <20250106085554.GA19343@lst.de> (raw)
In-Reply-To: <10f1383a-fe7e-4cf8-a15f-14cd4385a7de@oracle.com>
On Mon, Jan 06, 2025 at 08:50:20AM +0000, John Garry wrote:
>> .can_queue = SIL24_MAX_CMDS,
>> .sg_tablesize = SIL24_MAX_SGE,
>> .dma_boundary = ATA_DMA_BOUNDARY,
>> - .tag_alloc_policy = BLK_TAG_ALLOC_FIFO,
>
> nit: maybe that could be a separate patch, but no biggie
I though about that, but if felt a bit overkill.
>> + /*
>> + * Allocate tags starting from last allocated tag.
>> + */
>> + bool tag_alloc_policy_rr : 1;
>
> Is it proper to use bool here? I am not sure. Others use unsigned int or
> unsigned.
Yes, you can use any unsigned type for a single-bit bitfield. Most of
the existing uses just predate the availability of bool or were copy
and pasted after that.
>
> nit: coding style elsewhere in scsi_host_template would be to use
> "tag_alloc_policy_rr:1;"
Yes, but that's against the normal kernel coding style, so we'd better
stop adding more of that.
next prev parent reply other threads:[~2025-01-06 8:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 8:35 more BLK_MQ_F_* simplification v2 Christoph Hellwig
2025-01-06 8:35 ` [PATCH 1/4] block: better split mq vs non-mq code in add_disk_fwnode Christoph Hellwig
2025-01-06 8:35 ` [PATCH 2/4] block: remove blk_mq_init_bitmaps Christoph Hellwig
2025-01-06 8:35 ` [PATCH 3/4] block: remove BLK_MQ_F_NO_SCHED Christoph Hellwig
2025-01-06 8:35 ` [PATCH 4/4] block: simplify tag allocation policy selection Christoph Hellwig
2025-01-06 8:50 ` John Garry
2025-01-06 8:55 ` Christoph Hellwig [this message]
2025-01-06 10:40 ` John Garry
2025-01-06 14:39 ` more BLK_MQ_F_* simplification v2 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2025-01-03 7:42 more BLK_MQ_F_* simplification Christoph Hellwig
2025-01-03 7:42 ` [PATCH 4/4] block: simplify tag allocation policy selection Christoph Hellwig
2025-01-03 9:33 ` John Garry
2025-01-06 7:35 ` Christoph Hellwig
2025-01-06 7:58 ` Christoph Hellwig
2025-01-06 8:06 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106085554.GA19343@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).