Re: [PATCH v2] ata: ahci: Use correct DMI identifier for ASUSPRO-D840SA LPM quirk

Niklas Cassel
2025-06-25T08:52:08Z

On Wed, Jun 25, 2025 at 06:29:58AM +0000, Andy Yang wrote:
> On Tuesday, June 24, 2025, Damien Le Moal <dlemoal@kernel.org> wrote:
> > On 6/24/25 4:40 PM, Niklas Cassel wrote:
> >> ASUS store the board name in DMI_PRODUCT_NAME rather than
> >> DMI_PRODUCT_VERSION. (Apparently it is only Lenovo that stores the
> >> model-name in DMI_PRODUCT_VERSION.)
> >>
> >> Use the correct DMI identifier, DMI_PRODUCT_NAME, to match the
> >> ASUSPRO-D840SA board, such that the quirk actually gets applied.
> >>
> >> Cc: stable@vger.kernel.org
> >> Reported-by: Andy Yang <andyybtc79@gmail.com>
> >> Closes: https://lore.kernel.org/linux-ide/aFb3wXAwJSSJUB7o@ryzen/
> >> Fixes: b5acc3628898 ("ata: ahci: Disallow LPM for ASUSPRO-D840SA
> motherboard")
> >> Reviewed-by: Hans de Goede <hansg@kernel.org>
> >> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> >
> > Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> >
> >
> > --
> > Damien Le Moal
> > Western Digital Research
> >
>
> LGTM. This patch is tested work correctly.

Thank you, I will add your Tested-by tag.

>
> Again, not sure if its model specific or motherboard specific, if its
> consider motherboard specific we should use (DMI_BOARD_NAME, D840MB)
> instead to match the board.

I don't know if it is model specific or motherboard specific.

Considering how bad this bug is (causing artifacts on the iGPU),
I guess we should hope that it is only the BIOS for your system,
and not for all D840MB boards.

So personally, I would go with the narrowest possible match (which
this patch currently does).

But, I would not be surprised if they actually managed to mess this
up for all boards. But until someone else reports the same problem,
I guess we should give them the benefit of the doubt.

Kind regards,
Niklas