Re: [PATCH] dt-bindings: ata: sun4i-a10: Add a reference to ahci-common.yaml

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

On Fri, Aug 22, 2025 at 03:17:49PM -0300, Fabio Estevam wrote:
> The 'target-supply' property is already documented in ahci-common.yaml.
> 
> Instead of documenting it locally, add a reference to ahci-common.yaml.
> 
> Also change to 'unevaluatedProperties: false' to allow the properties
> from ahci-common.yaml to be evaluated.

Are the other properties in ahci-common.yaml valid for this device?

> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  .../devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
> index 2011bd03cdcd..8826aed4ec03 100644
> --- a/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
> @@ -10,6 +10,9 @@ maintainers:
>    - Chen-Yu Tsai <wens@csie.org>
>    - Maxime Ripard <mripard@kernel.org>
>  
> +allOf:
> +  - $ref: ahci-common.yaml#
> +
>  properties:
>    compatible:
>      const: allwinner,sun4i-a10-ahci
> @@ -25,16 +28,13 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> -  target-supply:
> -    description: Regulator for SATA target power
> -
>  required:
>    - compatible
>    - reg
>    - clocks
>    - interrupts
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]