From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: [PATCH] ata: libata: Advertize device support for DIPM and HIPM features for ATAPI
Date: Thu, 8 Jan 2026 15:12:34 +0100 [thread overview]
Message-ID: <20260108141234.2837566-2-cassel@kernel.org> (raw)
Commit b1f5af54f1f5 ("ata: libata-core: Advertize device support for DIPM
and HIPM features") added prints if the device supports DIPM and HIPM,
however, it forgot to update the same print for ATAPI devices.
Before changes:
ata1.00: ATAPI: Slimtype DVD A DU8AESH, 6C2M, max UDMA/133
After changes:
ata1.00: ATAPI: Slimtype DVD A DU8AESH, 6C2M, max UDMA/133 HIPM DIPM
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/ata/libata-core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b96105481784..20d539730553 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3143,11 +3143,13 @@ int ata_dev_configure(struct ata_device *dev)
/* print device info to dmesg */
if (print_info)
ata_dev_info(dev,
- "ATAPI: %s, %s, max %s%s%s%s\n",
+ "ATAPI: %s, %s, max %s%s%s%s%s%s\n",
modelbuf, fwrevbuf,
ata_mode_string(xfer_mask),
cdb_intr_string, atapi_an_string,
- dma_dir_string);
+ dma_dir_string,
+ ata_id_has_hipm(dev->id) ? " HIPM" : "",
+ ata_id_has_dipm(dev->id) ? " DIPM" : "");
}
/* determine max_sectors */
--
2.52.0
next reply other threads:[~2026-01-08 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 14:12 Niklas Cassel [this message]
2026-01-08 14:48 ` [PATCH] ata: libata: Advertize device support for DIPM and HIPM features for ATAPI Niklas Cassel
2026-01-08 15:32 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108141234.2837566-2-cassel@kernel.org \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox