public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: dlemoal@kernel.org
Cc: linux-ide@vger.kernel.org, wolf@yoxt.cc,
	Niklas Cassel <cassel@kernel.org>
Subject: [PATCH v2 0/6] misc LPM related fixes
Date: Mon, 12 Jan 2026 13:20:45 +0100	[thread overview]
Message-ID: <20260112122044.143637-8-cassel@kernel.org> (raw)

Hello there,

we had a recent bug report on the mailing list related to LPM, which made
me review the LPM related code.

While doing so, I found some issues. This series fixes those issues.

The most serious issue is that ATA_QUIRK_NOLPM was not getting applied for
ATAPI devices and that we read the per port area for unimplemented ports,
even though the AHCI specification explicitly forbids this.


Kind regards,
Niklas


Changes since v1:
-Fixed typos in commit messages
-Split early return patch into two, so that they only have a single
 Fixes-tag each.
-Reordered patches to make it easier to only apply the important ones
 for the current v6.19 kernel.


Niklas Cassel (6):
  ata: ahci: Do not read the per port area for unimplemented ports
  ata: libata: Call ata_dev_config_lpm() for ATAPI devices
  ata: libata-sata: Improve link_power_management_supported sysfs
    attribute
  ata: libata: Add cpr_log to ata_dev_print_features() early return
  ata: libata: Add DIPM and HIPM to ata_dev_print_features() early
    return
  ata: libata: Print features also for ATAPI devices

 drivers/ata/ahci.c        | 10 +++++-----
 drivers/ata/libata-core.c |  8 +++++++-
 drivers/ata/libata-sata.c |  2 +-
 3 files changed, 13 insertions(+), 7 deletions(-)


base-commit: 97e01439e902b743b8f89497e9c144e3ddda5e59
-- 
2.52.0


             reply	other threads:[~2026-01-12 12:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 12:20 Niklas Cassel [this message]
2026-01-12 12:20 ` [PATCH v2 1/6] ata: ahci: Do not read the per port area for unimplemented ports Niklas Cassel
2026-01-12 12:20 ` [PATCH v2 2/6] ata: libata: Call ata_dev_config_lpm() for ATAPI devices Niklas Cassel
2026-01-12 12:20 ` [PATCH v2 3/6] ata: libata-sata: Improve link_power_management_supported sysfs attribute Niklas Cassel
2026-01-12 13:17   ` Damien Le Moal
2026-01-12 14:39     ` Niklas Cassel
2026-01-12 15:05       ` Damien Le Moal
2026-01-12 15:08         ` Niklas Cassel
2026-01-12 12:20 ` [PATCH v2 4/6] ata: libata: Add cpr_log to ata_dev_print_features() early return Niklas Cassel
2026-01-12 12:20 ` [PATCH v2 5/6] ata: libata: Add DIPM and HIPM " Niklas Cassel
2026-01-12 12:20 ` [PATCH v2 6/6] ata: libata: Print features also for ATAPI devices Niklas Cassel
2026-01-12 16:12 ` [PATCH v2 0/6] misc LPM related fixes wolf
2026-01-13 10:02 ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260112122044.143637-8-cassel@kernel.org \
    --to=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=wolf@yoxt.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox