[PATCH v3] ata: pata_arasan_cf: fix missing newline in dev_err() messages

[PATCH v3] ata: pata_arasan_cf: fix missing newline in dev_err() messages

[Haoyu Lu]

Add missing trailing newlines to dev_err() messages in pata_arasan_cf.c.

This keeps the error output as properly terminated log lines.

Acked-by: Viresh Kumar <vireshk@kernel.org>
Signed-off-by: Haoyu Lu <hechushiguitu666@gmail.com>
---
Changes in v3:
- Rebase on libata/for-next branch as requested
- Correct Acked-by tag (was Reviewed-by in v2)

Changes in v2:
- Change subject to include parentheses in dev_err()

 drivers/ata/pata_arasan_cf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index 514d549286b5..abcdef123456 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
@@ -380,7 +380,7 @@ static inline int wait4buf(struct arasan_cf_dev *acdev)
 	if (!wait_for_completion_timeout(&acdev->cf_completion, TIMEOUT)) {
 		u32 rw = acdev->qc->tf.flags & ATA_TFLAG_WRITE;

-		dev_err(acdev->host->dev, "%s TimeOut", rw ? "write" : "read");
+		dev_err(acdev->host->dev, "%s TimeOut\n", rw ? "write" : "read");
 		return -ETIMEDOUT;
 	}

@@ -474,7 +474,7 @@ static int sg_xfer(struct arasan_cf_dev *acdev, struct scatterlist *sg)
 			dma_len = min(xfer_cnt, FIFO_SIZE);
 			ret = dma_xfer(acdev, src, dest, dma_len);
 			if (ret) {
-				dev_err(acdev->host->dev, "dma failed");
+				dev_err(acdev->host->dev, "dma failed\n");
 				goto fail;
 			}

--
2.17.1

Re: [PATCH v3] ata: pata_arasan_cf: fix missing newline in dev_err() messages

[Damien Le Moal]

On 4/3/26 11:07, Haoyu Lu wrote:
> Add missing trailing newlines to dev_err() messages in pata_arasan_cf.c.
> 
> This keeps the error output as properly terminated log lines.
> 
> Acked-by: Viresh Kumar <vireshk@kernel.org>
> Signed-off-by: Haoyu Lu <hechushiguitu666@gmail.com>

Looks OK.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH v3] ata: pata_arasan_cf: fix missing newline in dev_err() messages

[Niklas Cassel]

On Fri, 03 Apr 2026 10:07:09 +0800, Haoyu Lu wrote:
> Add missing trailing newlines to dev_err() messages in pata_arasan_cf.c.
> 
> This keeps the error output as properly terminated log lines.
> 
> 

Applied to libata/linux.git (for-7.1), thanks!

[1/1] ata: pata_arasan_cf: fix missing newline in dev_err() messages
      https://git.kernel.org/libata/linux/c/797f6298

Kind regards,
Niklas