Re: [PATCH v5 6/6] scsi: scsi_devinfo: add COMPAQ PD-1 multi-LUN ATAPI device quirk

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Inconsistent application of the `BLIST_NO_LUN_1F` quirk for identical OEM hardware variants.
--

commit ab42e7feb93cffa0988b57200c3b29ed1da7f1c2
Author: Phil Pemberton <philpem@philpem.me.uk>

scsi: scsi_devinfo: add COMPAQ PD-1 multi-LUN ATAPI device quirk

This commit adds a SCSI device quirk for the COMPAQ PD-1 combo drive. It
adds BLIST_FORCELUN, BLIST_SINGLELUN, and BLIST_NO_LUN_1F to ensure
correct LUN scanning and serialize commands on the single transport.

> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> index 68a992494b121..bfc2cbd438975 100644
> --- a/drivers/scsi/scsi_devinfo.c
> +++ b/drivers/scsi/scsi_devinfo.c
> @@ -150,6 +150,8 @@ static struct {
>  	{"COMPAQ", "MSA1000", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
>  	{"COMPAQ", "MSA1000 VOLUME", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
>  	{"COMPAQ", "HSV110", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
> +	{"COMPAQ", "PD-1", NULL, BLIST_FORCELUN | BLIST_SINGLELUN |
> +				 BLIST_NO_LUN_1F},

The commit message notes that the COMPAQ PD-1 is an OEM Panasonic/Matsushita
drive. Since scsi_static_device_list already contains entries for MATSHITA
PD-1 and NEC PD-1 ODX654P which share the same underlying hardware, should
those entries also be updated to include the BLIST_NO_LUN_1F quirk?

Without it, wouldn't the MATSHITA and NEC variants still generate spurious
entries for unpopulated LUNs during scans? For example, the MATSHITA and NEC
entries currently only specify:

    {"MATSHITA", "PD-1", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
    ...
    {"NEC", "PD-1 ODX654P", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},

>  	{"DDN", "SAN DataDirector", "*", BLIST_SPARSELUN},
>  	{"DEC", "HSG80", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
>  	{"DELL", "PV660F", NULL, BLIST_SPARSELUN},

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512202728.299414-1-philpem@philpem.me.uk?part=6