Re: [PATCH v2 5/9] ata: libata: Pass the ATA port argument directly to ata_qc_issue()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing kernel-doc parameter documentation for 'ap'.
--

commit b81f096dbed2ff9052d6614eac11c53f07517937
Author: Bart Van Assche <bvanassche@acm.org>

ata: libata: Pass the ATA port argument directly to ata_qc_issue()

This commit prepares for adding lock context annotations by passing the ATA
port argument directly to ata_qc_issue(). No functionality has been changed.

> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
[ ... ]
> @@ -5159,9 +5159,8 @@ EXPORT_SYMBOL_GPL(ata_qc_get_active);
>   *	LOCKING:
>   *	spin_lock_irqsave(host lock)
>   */
> -void ata_qc_issue(struct ata_queued_cmd *qc)
> +void ata_qc_issue(struct ata_port *ap, struct ata_queued_cmd *qc)

[Severity: Low]
This isn't a bug, but should the kernel-doc comment block above this
function be updated to document the new ap parameter? It looks like this
might trigger a warning during documentation builds.

>  {
> -	struct ata_port *ap = qc->ap;
>  	struct ata_link *link = qc->dev->link;
>  	u8 prot = qc->tf.protocol;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521173347.2079560-1-bvanassche@acm.org?part=5