From: Rosen Penev <rosenp@gmail.com>
To: linux-ide@vger.kernel.org
Cc: Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>,
Jeff Garzik <jgarzik@redhat.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 4/4] ata: pata_mpc52xx: use devm_platform_get_and_ioremap_resource
Date: Mon, 8 Jun 2026 14:47:18 -0700 [thread overview]
Message-ID: <20260608214718.49503-5-rosenp@gmail.com> (raw)
In-Reply-To: <20260608214718.49503-1-rosenp@gmail.com>
Replace the open-coded sequence of of_address_to_resource(),
devm_request_mem_region(), and devm_ioremap() with the standard
devm_platform_get_and_ioremap_resource() helper.
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/ata/pata_mpc52xx.c | 29 ++++++-----------------------
1 file changed, 6 insertions(+), 23 deletions(-)
diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
index d27390eda98e..3c41a7b860bd 100644
--- a/drivers/ata/pata_mpc52xx.c
+++ b/drivers/ata/pata_mpc52xx.c
@@ -20,7 +20,6 @@
#include <linux/delay.h>
#include <linux/libata.h>
#include <linux/of.h>
-#include <linux/of_address.h>
#include <linux/platform_device.h>
#include <linux/types.h>
@@ -671,7 +670,7 @@ static int mpc52xx_ata_init_one(struct device *dev,
static int mpc52xx_ata_probe(struct platform_device *op)
{
unsigned int ipb_freq;
- struct resource res_mem;
+ struct resource *res_mem;
int ata_irq = 0;
struct mpc52xx_ata __iomem *ata_regs;
struct mpc52xx_ata_priv *priv = NULL;
@@ -688,25 +687,9 @@ static int mpc52xx_ata_probe(struct platform_device *op)
return -ENODEV;
}
- /* Get device base address from device tree, request the region
- * and ioremap it. */
- rv = of_address_to_resource(op->dev.of_node, 0, &res_mem);
- if (rv) {
- dev_err(&op->dev, "could not determine device base address\n");
- return rv;
- }
-
- if (!devm_request_mem_region(&op->dev, res_mem.start,
- sizeof(*ata_regs), DRV_NAME)) {
- dev_err(&op->dev, "error requesting register region\n");
- return -EBUSY;
- }
-
- ata_regs = devm_ioremap(&op->dev, res_mem.start, sizeof(*ata_regs));
- if (!ata_regs) {
- dev_err(&op->dev, "error mapping device registers\n");
- return -ENOMEM;
- }
+ ata_regs = devm_platform_get_and_ioremap_resource(op, 0, &res_mem);
+ if (IS_ERR(ata_regs))
+ return PTR_ERR(ata_regs);
/*
* By default, all DMA modes are disabled for the MPC5200. Some
@@ -740,7 +723,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
priv->ipb_period = 1000000000 / (ipb_freq / 1000);
priv->ata_regs = ata_regs;
- priv->ata_regs_pa = res_mem.start;
+ priv->ata_regs_pa = res_mem->start;
priv->ata_irq = ata_irq;
priv->csel = -1;
priv->mpc52xx_ata_dma_last_write = -1;
@@ -777,7 +760,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
}
/* Register ourselves to libata */
- rv = mpc52xx_ata_init_one(&op->dev, priv, res_mem.start,
+ rv = mpc52xx_ata_init_one(&op->dev, priv, res_mem->start,
mwdma_mask, udma_mask);
if (rv) {
dev_err(&op->dev, "error registering with ATA layer\n");
--
2.54.0
prev parent reply other threads:[~2026-06-08 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 21:47 [PATCH 0/4] ata: pata_mpc52xx: fix cleanup ordering and modernize Rosen Penev
2026-06-08 21:47 ` [PATCH 1/4] ata: pata_mpc52xx: switch to non-devm request_irq for proper ordering Rosen Penev
2026-06-08 21:59 ` sashiko-bot
2026-06-09 7:20 ` Niklas Cassel
2026-06-09 8:36 ` Andy Shevchenko
2026-06-08 21:47 ` [PATCH 2/4] ata: pata_mpc52xx: remove redundant irq_dispose_mapping calls Rosen Penev
2026-06-08 21:47 ` [PATCH 3/4] ata: pata_mpc52xx: convert to platform_get_irq() Rosen Penev
2026-06-08 21:47 ` Rosen Penev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608214718.49503-5-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox