Re: [PATCH 17/37] scsi: mpt3sas: use 16-bits defined sense codes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Data race on static local variable 'rc' in _scsih_determine_disposition causing erratic device discovery states.
--

commit 494f343d73ff2ef15d8e6f7b1ea653d86adb0fd3
Author: Damien Le Moal <dlemoal@kernel.org>

scsi: mpt3sas: use 16-bits defined sense codes

This commit refactors the mpt3sas driver to replace hard-coded sense codes
with the enum values defined in include/scsi/scsi_sense.h. This improves
code clarity and self-documentation.

> diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> index 0e12009a87f62..085d4672db854 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
[ ... ]
> @@ -7691,38 +7691,41 @@ _scsih_determine_disposition(struct MPT3SAS_ADAPTER *ioc,
>  
>  	if (check_sense) {
>  		_scsih_normalize_sense(transfer_packet->sense, &sense_info);
> -		if (sense_info.skey == UNIT_ATTENTION)
> +		if (sense_info.skey == UNIT_ATTENTION) {
>  			rc = DEVICE_RETRY_UA;

[Severity: High]
This is a pre-existing issue, but I noticed a potential data race involving
the variable rc in this function. At the beginning of
_scsih_determine_disposition(), it is declared as a static local variable:

static enum device_responsive_state rc;

Because this variable is static, it is shared across all concurrent executions
of the function. If multiple threads (such as from asynchronous SCSI scanning
or event handlers) execute this concurrently, could one thread overwrite the
disposition state calculated by another?

If this overwrite occurs, would it cause devices to be incorrectly marked
offline, skipped, or subjected to invalid retry loops? Does this variable
need to be static, or can it be changed to a standard local variable?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831020451.585944-1-dlemoal@kernel.org?part=17