From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DD42380FEE; Thu, 3 Sep 2026 03:43:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788406993; cv=none; b=qTX4sU6ZrXaTy1JEofDiYxTuubmFX5tGLntWsyEAFDlUpZP/JTO022fdJ7C8iLVUnxrKIKbFX3WA3p3szlAF6LZiHb7hS7O2Nl75Y9dpxk0I0Jk4yBWIVb3PfEUe8741hMv+a1tH7T+T6Td+aR9yyui+6O3U99dlR3zAS/O4xco= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788406993; c=relaxed/simple; bh=/mW41zqDDqdpOsgXHkPmsVI/0GS/DDbcEJiTrCb2nMc=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ABeo8TKV6kF6JsFkq4pBldE4xmRfKoQWP7hhNrXwdkVhsghvh44eRFQ6ge742l5maKEiUiF/lUr/Rzbk+ltwMn8ell3Padm+YJp9a0B0iNFM+eXXvxePOoqbiwuNiJePGKkYQVL9zX3Hr5VdMZhRDii8Y/FBb9vaCgXO2sH7q08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PRwHqlPX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PRwHqlPX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97FA51F00A3E; Thu, 3 Sep 2026 03:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788406988; bh=ezZo3cIeZob5n0jUfDw8efAraNLL9XA404n3FNk6lwA=; h=From:To:Subject:Date:In-Reply-To:References; b=PRwHqlPXhMh/VIbmmoc0NZJWwXnkRqsZmOBBQ0CRO7ecKcUVLh4fdD+0zl5Oa+2BG gwV3ZKHFBPjGyNqZ0IeZXcKGETrAnylQ0kcxSfGQM+G6I8uD0qcZUAUHzl7t5fQLD5 yU7RPq6OAEzfZwV1/+PAUW8eAGaQVqbUbUFIcSon4SLNrkVJn8HKtmvwY9FNqPKOUE RuhdmkxIbtCgMP4eozg51zD/lryWISzGQGnqdivAqhcnkxN9OUNwwhvDqidrVs+ePU 6UxPFjnwvHoCFwJbQnXrLMXcdJtajMDgwgN4X1w7vIByqj3ugR8zKl6Y2puNyHdzBQ PNtn1xTo/l9BA== From: Damien Le Moal To: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Niklas Cassel , linux-usb@vger.kernel.org, Alan Stern , Greg Kroah-Hartman , linux-s390@vger.kernel.org, Heiko Carstens Subject: [PATCH v2 29/40] scsi: libiscsi: use 16-bits defined sense codes Date: Thu, 3 Sep 2026 12:41:50 +0900 Message-ID: <20260903034201.112211-30-dlemoal@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260903034201.112211-1-dlemoal@kernel.org> References: <20260903034201.112211-1-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor libiscsi to use scsi_set_sense() and replace all hard-coded additional sense codes and additional sense code qualifiers with the enum values defined in include/scsi/scsi_sense.h. This helps with code clarity as the sense codes being processed are easier to test and self-documented. No functional change intended. Signed-off-by: Damien Le Moal --- drivers/scsi/libiscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index 5cbc51899de0..7637aacd6037 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -892,7 +892,8 @@ static void iscsi_scsi_cmd_rsp(struct iscsi_conn *conn, struct iscsi_hdr *hdr, ascq = session->tt->check_protection(task, §or); if (ascq) { - scsi_build_sense(sc, 1, ILLEGAL_REQUEST, 0x10, ascq); + scsi_set_sense(sc, 1, ILLEGAL_REQUEST, + scsi_sense_code(ASC_ID_CRC_OR_ECC_ERROR, ascq)); scsi_set_sense_information(sc->sense_buffer, SCSI_SENSE_BUFFERSIZE, sector); -- 2.55.0