From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 405DB378D9A; Sat, 5 Sep 2026 03:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788578617; cv=none; b=UvULm5Hc/vDXPSdE1jxIbve/YRnLVn+p51fPoxVR9uiBDptbBO1eA/Cu6nwssZvSQvWCd9EgCTsuMTOZSyuTwPfq0Gn64yqcvtNLl67vWdr72Q6w8O1L99RpJs9qEnb00xj4eHWi/jtPZzKkp5O4eoWoPNfEBtawQZKUwItuAMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788578617; c=relaxed/simple; bh=UEkksSlxyFrOyMXmYUcci/0laVXNLurv0stVKLOhYPY=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tT8UJbUXPA8QQ92jaYD01C+y6WnUGHpyh1wSbNuyhHTl+Lv4P3D7D3JlHWnd/gZ/9DzlIz35Lvw9HeFql1LmhwHw2bpbKhAz8We8Os9OzlLPmIsR3TZC7CWpGNBKtI42RUQCbho92hqHZmZVEf+Q4GAv1fsJpjI6tBOWtQoiAvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Be5e4CEi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Be5e4CEi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCC0B1F00AC4; Sat, 5 Sep 2026 03:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788578616; bh=7EDmrAkNKY6icF6hbFNSI+9lqeNwbzVCdBaXNPEH1Gc=; h=From:To:Subject:Date:In-Reply-To:References; b=Be5e4CEiLCIm/Y+a6ki4+VRZEod3D+yF45DeesW5NlHE8dCN/VRRPDvM+mihIUEdN l7Qp8KNdfHgjayecfnEk5L3uq1GJABeyD8mw6OtAaQZz5y0EBoxfwEadM33FpKLtGD zzzyEcYMsTgPRiXDGXW2vSrvBAn0ejKV6K70w6YGFrmsYKYY9EoGVQoDN876VJipiM 2AqykLh2RThFdIZZGVCq+yS/FLeClKsvVsV8xLBiU11+WIl+LgG1kQFP1/rJoMIZj2 dlezWmogcMfDIjly7oK338vtsX+8lC3sMulyYAfbKWntl2CpgYXTbp7ZWizKvqWYbA 8Pn3eLx8cR/5Q== From: Damien Le Moal To: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Niklas Cassel , linux-usb@vger.kernel.org, Alan Stern , Greg Kroah-Hartman , linux-s390@vger.kernel.org, Heiko Carstens Subject: [PATCH v4 33/40] scsi: storvsc: use 16-bits defined sense codes Date: Sat, 5 Sep 2026 12:22:17 +0900 Message-ID: <20260905032224.509860-34-dlemoal@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260905032224.509860-1-dlemoal@kernel.org> References: <20260905032224.509860-1-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor the storvsc driver to use the 16-bits sense_code field of struct scsi_sense_hdr and replace all hard-coded additional sense codes and additional sense code qualifiers with the enum values defined in include/scsi/scsi_sense.h. This helps with code clarity as the sense codes being processed are easier to test and self-documented. No functional change intended. Signed-off-by: Damien Le Moal --- drivers/scsi/storvsc_drv.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index ef3cd3bc7390..625db97d1a03 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -1016,7 +1016,7 @@ static int storvsc_channel_init(struct hv_device *device, bool is_fc) static void storvsc_handle_error(struct vmscsi_request *vm_srb, struct scsi_cmnd *scmnd, struct Scsi_Host *host, - u8 asc, u8 ascq) + struct scsi_sense_hdr *sshdr) { struct storvsc_scan_work *wrk; void (*process_err_fn)(struct work_struct *work); @@ -1033,7 +1033,7 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb, case SRB_STATUS_DATA_OVERRUN: if (vm_srb->srb_status & SRB_STATUS_AUTOSENSE_VALID) { /* Check for capacity change */ - if ((asc == 0x2a) && (ascq == 0x9)) { + if (sshdr->sense_code == CAPACITY_DATA_HAS_CHANGED) { process_err_fn = storvsc_device_scan; /* Retry the I/O that triggered this. */ set_host_byte(scmnd, DID_REQUEUE); @@ -1049,8 +1049,12 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb, * want scsi_report_sense() to output a message * that a sysadmin wouldn't know what to do with. */ - if ((asc == 0x3f) && (ascq != 0x03) && - (ascq != 0x0e)) { + if (scsi_sense_asc(sshdr) == + ASC_TARGET_OPERATING_CONDITIONS_HAVE_CHANGED && + sshdr->sense_code != + INQUIRY_DATA_HAS_CHANGED && + sshdr->sense_code != + REPORTED_LUNS_DATA_HAS_CHANGED) { process_err_fn = storvsc_device_scan; set_host_byte(scmnd, DID_REQUEUE); goto do_work; @@ -1141,8 +1145,7 @@ static void storvsc_command_completion(struct storvsc_cmd_request *cmd_request, } if (vm_srb->srb_status != SRB_STATUS_SUCCESS) { - storvsc_handle_error(vm_srb, scmnd, host, sense_hdr.asc, - sense_hdr.ascq); + storvsc_handle_error(vm_srb, scmnd, host, &sense_hdr); /* * The Windows driver set data_transfer_length on * SRB_STATUS_DATA_OVERRUN. On other errors, this value -- 2.55.0