From: Nikolay Borisov <nik.borisov@suse.com>
To: linux-ide@vger.kernel.org
Cc: dlemoal@kernel.org, cassel@kernel.org, rosenp@gmail.com,
Nikolay Borisov <nik.borisov@suse.com>
Subject: [PATCH] ata: sata_dwc_460ex: Don't enable interrupt if libATA core registration fails
Date: Tue, 8 Sep 2026 17:15:38 +0300 [thread overview]
Message-ID: <20260908141538.731237-1-nik.borisov@suse.com> (raw)
Recent 4bbc16a353a9 commit changed the timing when interrupts are
enabled. However it didn't account for the libATA registration step. So
it's possible that interrupts are enabled when the device is not
registered with libATA core.
Resolve the issue by failing the entire registration process in case of
failure to register with libATA.
Fixes: 4bbc16a353a9 ("ata: sata_dwc_460ex: enable SATA interrupts only after IRQ handler is registered")
Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
---
This was discovered during review of an internal backport by some internal
LLM-based tool but the fix is entirely cooked up by me.
drivers/ata/sata_dwc_460ex.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index 8e3fc713891a..c3df2fce4af7 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -1185,8 +1185,10 @@ static int sata_dwc_probe(struct platform_device *ofdev)
* error_handler() to execute a dummy Softreset EH session
*/
err = ata_host_activate(host, irq, sata_dwc_isr, 0, &sata_dwc_sht);
- if (err)
+ if (err) {
dev_err(dev, "failed to activate host");
+ goto err;
+ }
/* Enable SATA Interrupts */
sata_dwc_enable_interrupts(hsdev);
--
2.55.0
next reply other threads:[~2026-09-08 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 14:15 Nikolay Borisov [this message]
2026-09-08 14:30 ` [PATCH] ata: sata_dwc_460ex: Don't enable interrupt if libATA core registration fails sashiko-bot
2026-09-08 14:34 ` Nikolay Borisov
2026-09-09 9:27 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908141538.731237-1-nik.borisov@suse.com \
--to=nik.borisov@suse.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox