From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs2-f39.google.com (mail-vs2-f39.google.com [74.125.227.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 407234E2F15 for ; Fri, 25 Sep 2026 21:28:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.39 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790371736; cv=none; b=aNh1M4FlMrJH+fBrHwcsvX3BCQqlgoKuNjXrazhK6OKyxycDDYjIBJ4/Z5HxtKX9QkFEx35cMhinmPRVcgU7+Gqu0kD1Va0U/DiE2TeO21rW1jRLf1dqedmTQFHenoCOap3kwItM9ur/uC1b4HCdm/8JAe1MLk30JTsUg5c4ZeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790371736; c=relaxed/simple; bh=DsHX2LZCKnEVLh0jcJ3cHqzEi/P8RRApIj3SMsCChm8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TwTqO2yvETzJv636LkmukXEY0WTnMlJZDy36kzXdMspjwyZIv8anb+LhNdi6bbmRZhSkaKP+cBdaneRPb3++y8RX2LouxxmVj9N2zrBLdaKFdS1Nps2fhhBVPapUXSf4ElACPegDq3J/leUGZ/WZ3yOY2cADmX2VdPkRcdjCO9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZIKCIy3g; arc=none smtp.client-ip=74.125.227.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZIKCIy3g" Received: by mail-vs2-f39.google.com with SMTP id ada2fe7eead31-7b23989f7baso59439137.2 for ; Fri, 25 Sep 2026 14:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790371733; x=1790976533; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T5DE0JGxeDqZIZp7U5YbtubrIM9R70QWPvzhrKHb2cI=; b=ZIKCIy3g9Zoh+Hio57nA4huRPLFnMTUrGsTQVaFi9qnrgPCXXbowyuuX4IyysJEzy5 4mMfW1cVvkXLOyHjrScSNre2qRCMkTBEyFO9F9c8AbMHryjSHCOiKRr8IpDqz3w+Zatf 2oiWdUWd4/PRw39OoWV9lKgRxCShVL0pLZ221VEBy15jpzig4p2Z6UqTPHwlC7PQi5oF tkI/Z0/fVBM16iwYgcCjN204PFMYvpl/M37kg9ECUtmBkTdWlPYjSLwutv/p20fshppd N3h9hb2geM3vyoHpGTFSTkwBX2ytUEmKCvQZPBHCcdo5noMVo+qJhCxJT33n7NADBPSh jwow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790371733; x=1790976533; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=T5DE0JGxeDqZIZp7U5YbtubrIM9R70QWPvzhrKHb2cI=; b=dMnD+xDEcwATVYdepdTO7TQbKb5rGI+fSsjulp+1oXLUJIh16bHbNb7twFC2i4d+Pq Y8emKD+DjyrLCIc5Cn3CsukpKezhd5UUzSjWPerJubq4rULiZJtKe9hYPZtIRCDh9iMP RenF62ifQxLBpMZUN39Osc0QELlExHWkrdrlT2wrnRcTcsbzWDKFz3Eksz0nqlOq6UVf C4LHYz97Fph4o1TkX/bcpPvqy+MDzvZ1IN5wnlwhJmOcwwDCSGlpsD5KQT5plqMq2vSu mFNSFU58/3D6mbOUkrhy1q2/BWwrGI2auGBvKAiwjr44RqoOAV+5GxTTpO8sOfMepSbo eGqg== X-Forwarded-Encrypted: i=1; AKwUvBxmDC6djdDJhHxfRtPrWkn36i/uVyeW07yzzaZrX+vJKhHq0MOEloGb5AD0SNegK8O181BDT+xj9wc=@vger.kernel.org X-Gm-Message-State: AFuF++m0enUAbJdzeYgA4YI1qgsu4ApPYOZapdjOWPX8F+DFqV6vJfG7 E10RSKJYCwsANQgdflSz0e00hnZPxR977dusGi596RZre1iSDrhLzVi2 X-Gm-Gg: AYBFou2cSI5RJIfTuhSrWA3MC0fUDXhqP/UlIOGge7yNcghpqsd0pqaihy9/b75yJzz wzK1PSL+pc2/pC+aixgIbVX78J11JeLwAHtMAf3xwArBuxtkFROwT72vSGGANMbrZi2evcK7ctc MsdwUdD2XzgioNp+3n3IIlyAJadcJCPe8QB2qZeqTqTwB+OGn8z1Fx5NEPVjcpXoUsI8ctABO2L xbd5kXyHba7HUgWUs17NfzFASFe6ER4N9hsU7Qkw5Fgv1GaLxhyPrkq9ebuHm1JosAvnVt4CRLX UwqvZpo+pqr+tsZq2jMk/2bCc9UyuIuHvX87+GOWcT6W5ZVp4G2mWMSn2QeNQBK3IrhKrmdMqIB 0WeBEF9qnYiV9qIBZPA1w9E0hDkO64QfEg8yh7HuIaLqxRXnzyK8cM7e296DAVKt/oggyKTyDya 1QmbvNgLelzFNXoV19ehlcXLjHD2KHnYEqE2mj4RjCeuEb12m3Q1HfidLma3Mg4mpG3aM1c4LZ6 UOENlVz+E13OAYIFl3/VtgNUzA8mA== X-Received: by 2002:a05:6102:54a1:b0:7ae:544d:b36c with SMTP id ada2fe7eead31-7b08e842851mr1125366137.3.1790371732886; Fri, 25 Sep 2026 14:28:52 -0700 (PDT) Received: from Tifa.lan ([2804:1124:fd10:e01:ca0a:a9ba:b012:aee1]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-7b39b9af306sm382132137.9.2026.09.25.14.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 14:28:52 -0700 (PDT) From: Carlos Junior To: dlemoal@kernel.org Cc: cassel@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Carlos Junior Subject: [PATCH v2] ata: sata_mv: enable SoC SATA LED presence indication Date: Fri, 25 Sep 2026 18:28:23 -0300 Message-ID: <20260925212823.121415-1-cjuniorfox@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260925193134.114566-1-cjuniorfox@gmail.com> References: <20260925193134.114566-1-cjuniorfox@gmail.com> Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Enable the SoC SATA LED controller in mv_soc_enable_leds(). Set the LED controller enable and device presence multiplexing bits in the SoC SATA host-controller register. This enables SATA device presence indication on boards using the SoC SATA controller. Signed-off-by: Carlos Junior --- Changes in v2: - Do not initialize the SoC SATA LED blink bit; leave it to the existing NCQ LED blink handling. drivers/ata/sata_mv.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index d260f04e6..52e33485b 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -252,6 +252,7 @@ enum { SOC_LED_CTRL_BLINK = (1 << 0), /* Active LED blink */ SOC_LED_CTRL_ACT_PRESENCE = (1 << 2), /* Multiplex dev presence */ /* with dev activity LED */ + SOC_LED_CTRL_ENABLE = (1 << 3), /* Enable SATA LED control */ /* Shadow block registers */ SHD_BLK = 0x100, @@ -3382,12 +3383,20 @@ static void mv6_phy_errata(struct mv_host_priv *hpriv, void __iomem *mmio, writel(m2, port_mmio + PHY_MODE2); } -/* TODO: use the generic LED interface to configure the SATA Presence */ -/* & Acitivy LEDs on the board */ +/* + * Enable the SoC SATA LED controller and device presence + * indication on the board's SATA LEDs. + */ static void mv_soc_enable_leds(struct mv_host_priv *hpriv, void __iomem *mmio) { - return; + void __iomem *hc_mmio; + + hc_mmio = mv_hc_base(mmio, 0); + + writel(SOC_LED_CTRL_ENABLE | + SOC_LED_CTRL_ACT_PRESENCE, + hc_mmio + SOC_LED_CTRL); } static void mv_soc_read_preamp(struct mv_host_priv *hpriv, int idx, -- 2.54.0