From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: [PATCH] ata: libata-core: remove two WDC BROKEN_HPA quirks that never match
Date: Tue, 17 Nov 2026 14:02:39 +0100 [thread overview]
Message-ID: <20261117130238.3472718-2-cassel@kernel.org> (raw)
The second field of a __ata_dev_quirks[] entry is matched against the
firmware revision of the device, which ata_dev_quirks() reads into a
buffer of ATA_ID_FW_REV_LEN (8) characters. The ATA_QUIRK_BROKEN_HPA
entries for "WDC WD3200JD-00KLB0" and "WDC WD2500JD-00HBB0" instead
contain "WD-WCAMR1130137" and "WD-WMAL71490727", which look like drive
serial numbers. Without wildcards, these 15 character patterns can never
match a firmware revision, so the two entries have not applied to any
drive since they were added in commit 16c55b038033 ("libata: implement
BROKEN_HPA horkage and apply it to affected drives").
Remove them. The quirks applied to all drives are unchanged: these
models keep getting their quirks from the "WDC WD2500JD-*" and
"WDC WD3200JD-*" entries.
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/ata/libata-core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 2a5ca1b9ee5c..96aa941c4810 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4331,8 +4331,6 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
/* devices which puke on READ_NATIVE_MAX */
{ "HDS724040KLSA80", "KFAOA20N", ATA_QUIRK_BROKEN_HPA },
- { "WDC WD3200JD-00KLB0", "WD-WCAMR1130137", ATA_QUIRK_BROKEN_HPA },
- { "WDC WD2500JD-00HBB0", "WD-WMAL71490727", ATA_QUIRK_BROKEN_HPA },
{ "MAXTOR 6L080L4", "A93.0500", ATA_QUIRK_BROKEN_HPA },
/* this one allows HPA unlocking but fails IOs on the area */
--
2.56.1
next reply other threads:[~2026-11-17 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 13:02 Niklas Cassel [this message]
2026-11-17 13:07 ` [PATCH] ata: libata-core: remove two WDC BROKEN_HPA quirks that never match Damien Le Moal
2026-11-17 13:25 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117130238.3472718-2-cassel@kernel.org \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox