From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Lothar_Wa=C3=9Fmann?= Subject: Re: [PATCH V3 07/12] ata/sata_mv: Remove conditional compilation of clk code Date: Tue, 24 Apr 2012 14:51:00 +0200 Message-ID: <20374.41396.280974.710188@ipc1.ka-ro> References: <20120424120019.GE24089@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20120424120019.GE24089@lunn.ch> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Lunn Cc: Viresh Kumar , mturquette@linaro.org, sshtylyov@mvista.com, spear-devel@list.st.com, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, viresh.linux@gmail.com, linux@arm.linux.org.uk, akpm@linux-foundation.org, jgarzik@redhat.com, linux-arm-kernel@lists.infradead.org List-Id: linux-ide@vger.kernel.org Hi, Andrew Lunn writes: > > -#if defined(CONFIG_HAVE_CLK) > > hpriv->clk =3D clk_get(&pdev->dev, NULL); > > - if (IS_ERR(hpriv->clk)) > > - dev_notice(&pdev->dev, "cannot get clkdev\n"); > > - else > > - clk_enable(hpriv->clk); > > -#endif > > + if (IS_ERR(hpriv->clk)) { > > + dev_err(&pdev->dev, "cannot get clkdev\n"); > > + return PTR_ERR(hpriv->clk); > > + } > > + > > + clk_enable(hpriv->clk); >=20 > Sorry, but still wrong. >=20 > The clock is optional. If we can find a clock, turn it on. If not, > keep going.... >=20 > You patch causes the missing clock to become a fatal error. >=20 The clock API should accept NULL pointers as valid clocks and treat them as NOP. Thus drivers wouldn't have to worry about whether they actually got a clock to manage or if their clocks are just dummies. Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________