From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Lothar_Wa=C3=9Fmann?= Subject: Re: [PATCH V3 07/12] ata/sata_mv: Remove conditional compilation of clk code Date: Wed, 25 Apr 2012 10:35:53 +0200 Message-ID: <20375.46953.269684.680915@ipc1.ka-ro> References: <20120424120019.GE24089@lunn.ch> <20120424201802.GE3628@n2100.arm.linux.org.uk> <20120425052802.GF13489@lunn.ch> <20375.40225.227084.644318@ipc1.ka-ro> <20120425071418.GA2116@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail.karo-electronics.de ([81.173.242.67]:52618 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754890Ab2DYIgh (ORCPT ); Wed, 25 Apr 2012 04:36:37 -0400 In-Reply-To: <20120425071418.GA2116@lunn.ch> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Andrew Lunn Cc: viresh kumar , Russell King - ARM Linux , sshtylyov@mvista.com, spear-devel@list.st.com, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, mturquette@linaro.org, akpm@linux-foundation.org, jgarzik@redhat.com, linux-arm-kernel@lists.infradead.org Andrew Lunn writes: > > AFAICT the PCI archs do not have HAVE_CLK enabled. Thus they will h= ave > > a dummy clk API in place that provides the driver with a non-error > > clk_get() return value. > =20 > Hi Lothar >=20 > Please could you explain this a little bit more. What exactly is a PC= I > arch? >=20 > Most of the Orion SoC have PCIe busses. Does this make them an PCI > arch? Because they also have HAVE_CLK. There are more SoCs with PCI. >=20 If an arch has HAVE_CLK enabled it must provide valid clocks (be it dummy clocks) for all devices it supports. Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________